A cleaner version of my branch feature/atrayano/faster_routing #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolod
previously approved these changes
Jun 26, 2023
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOS_SurfaceGridComp.F90
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOS_SurfaceGridComp.F90
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOS_SurfaceGridComp.F90
Show resolved
Hide resolved
|
pinging @zyj8881357 |
zhaobin74
previously approved these changes
Jun 26, 2023
|
Pinging @yvikhlya as well. I think he hit slow river-routing with MOM6 runs at NAS. Hopefully he can test this change to see if speed returns! |
gmao-rreichle
previously approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Thanks, @atrayano, for making this more tractable! Happy to approve.
One last suggestion: Would it be correct to rephrase the comment line as follows:
ntotal = sum(blocksizes) ! should be same as # of paired sources and sinks (npairs)
It would be helpful to clarify the meaning of "npairs".
zhaobin74
approved these changes
Jun 26, 2023
sdrabenh
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only changes the communication pattern during fresh water river runoff. It is zero diff in coupled mode, and obviously zero diff in EMIP since routing is not used in that mode. This was tested with coupled GEOS-MITgcm and resulted in significant speedup. But the code mods are only in GEOS_SurfaceGridComp.F90 and there is no assumption about the specific ocean model. I am hoping runs with MOM6 will also benefit from this