Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pnorris/#512 add additional radiation rrtmg tau and water path diagnostics #519

Conversation

dr0cloud
Copy link
Contributor

This is a PR to add extra diagnostic cloud fractions and in-cloud optical depths (on the column and the low/mid/high super-layers) that use the cloud sub-column generator actually called by RRTMG SW/LW rather than the MAX-RAN cloud overlap assumed by Chou-Suarez and ISCCP. There are important provisos noted in comments in the EXPORT definitions section of the Solar and Irrad Set_Services as to the use of these diagnostics.

The PR contains two main elements:

  1. The existing TAUTT is marked as DEPRECATED since it is in error and an improved TAUTTX export is added and should replace use of TAUTT.
  2. As in the description above CLDxxLW, CLDxxSW, CLDxxSWHB, and TAUxxPAR are added as new diagnostic exports.

Note on 0-diff: These changes are essentially zero-diff. The only field that is non-zero-diff is TAUTT and it is only changed to roundoff level (~1e-5) for efficiency purposes. The model evolution is zero-diff since TAUTT is a diagnostic export only. The other new exports are also diagnostic and do not affect the model state.

@dr0cloud dr0cloud added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jan 19, 2022
@dr0cloud dr0cloud requested a review from mathomp4 January 19, 2022 21:13
@dr0cloud dr0cloud requested a review from a team as a code owner January 19, 2022 21:13
dr0cloud and others added 2 commits January 20, 2022 08:26
@sdrabenh sdrabenh merged commit d5ae28c into develop Feb 3, 2022
@sdrabenh sdrabenh deleted the feature/pnorris/#512-add_additional_radiation_RRTMG_TAU_and_Water_Path_Diagnostics branch February 3, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants