Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error checking in mk_restarts executables #467

Merged
merged 4 commits into from
Nov 9, 2021

Conversation

weiyuan-jiang
Copy link
Contributor

This PR addresses issue #464 . @gmao-jkolassa , Would you please help test this branch with regrid.pl. ( catch, catchcnclm40, catchcnclm45, maybe landice)

@weiyuan-jiang weiyuan-jiang added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA These changes are contingent on other PRs (DNA=do not approve) labels Oct 7, 2021
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner October 7, 2021 20:02
@gmao-jkolassa
Copy link
Contributor

Thanks @weiyuan-jiang! I'll go ahead and test this for all the cases you mentioned.

@gmao-jkolassa
Copy link
Contributor

I tested this and it works for catch, catchcn and landice.

@gmao-jkolassa
Copy link
Contributor

@mathomp4 When running this for catch only there is still an error message that appears, which does not impact the results.
The error message is:
Use of uninitialized value $cnlist[0] in concatenation (.) or string at /discover/nobackup/jkolassa/regrid_test/GEOSgcm/install/bin//regrid.pl line 2766, <STDIN> line 6.
@weiyuan-jiang has a fix for it by changing some lines in regrid.pl, but since this would involve another GMAO_Shared PR we were wondering whether to put that in now or wait until another GMAO_Shared PR comes along (since as I said this does not actually impact the results for catch or catchcn).

What do you think?

@weiyuan-jiang weiyuan-jiang removed the Contingent - DNA These changes are contingent on other PRs (DNA=do not approve) label Oct 20, 2021
@weiyuan-jiang
Copy link
Contributor Author

@sdrabenh Scott, this branch has been tested and is ready to merge. Thanks

@sdrabenh sdrabenh merged commit 4a86862 into develop Nov 9, 2021
@sdrabenh sdrabenh deleted the feature/wjiang/check_varread_rc branch November 9, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants