Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDSL] Feature/evap subl pdf #1008

Merged
merged 59 commits into from
Oct 11, 2024
Merged

[NDSL] Feature/evap subl pdf #1008

merged 59 commits into from
Oct 11, 2024

Conversation

CharlesKrop
Copy link

GFDL_1M evap_subl_pdf loop port. Verified, fail at a few points due to known constant issue.

find_klcl port. Created to test QSat port. Verifies, but not integrated into the larger GFDL_1M port.

CharlesKrop and others added 30 commits August 2, 2024 14:28
@CharlesKrop
First bit of the evap_subl_pdf port. Initial calculation verifies, me…
75c155b 
…ltfrz does not.
@CharlesKrop
Updates to the evap_subl_pdf loop. meltfrz now verifies (excluding mi…
2a637ff 
…nor random errors on the order of 10^-8 which have yet to be investigated). evap and subl are believed to verify pending a fix to the cloud_effective_radius functions. Error in cloud_effective_radius functions appears to be a reappearance of the 32-bit precision errors previous noted when using these functions (errors are on the order of 10^-12). First attempt at hystpdf port, but still missing many pieces and does not execute.
@CharlesKrop
Additional minor changes to hystpdf, various other minor QOL changes
e34e449
@CharlesKrop
Merge branch 'dsl/develop' into feature/evap_subl_pdf
881811d
@FlorianDeconinck
SaturationVaporPressureTable code first pass
b30ae8d 
QSatIce missing before test can be done
@FlorianDeconinck
QSat_Ice_scalar_exact
cde8399
@FlorianDeconinck
Fix calculation. Table generates OK.
dd15d29
@FlorianDeconinck
Fix Murphy and CAM
e6b597c
@FlorianDeconinck
Rename estimate_table -> table
5e4e464 
Verbose the README
@CharlesKrop
Merge branch 'dsl/QSat' into feature/evap_subl_pdf
f75089f
@CharlesKrop
Creation of QSat stencil, which still needs a lot of work. Need to pu…
40cc636 
…sh this code back to dsl/qsat branch as well at some point to have a working qsat function to pull on for all needs, but for now it is in evap_subl_pdf for development so that I can test incorporating it into the evap loop
@CharlesKrop
Functional QSat module, fails at majority of points but error pattern…
4af83f6 
… suggests numerics are as close as I can get them while remaining true to Fortran
@CharlesKrop
Updates to QSat and a few other minor QOL changes
7907680
@CharlesKrop
One more change that wasn't staged for some reason
c59d081
@CharlesKrop
Functional QSat module. Can handle optional RAMP/PASCALS/DQSAT inputs…
b80185c 
…. Fails to verify at majority of points using original metric, has not been tested with new metrics. Error patterns of the ES tables suggest arise during math within qsat_liquid and qsat_ice. Errors are small (10^-4). Further testing using find_klcl is in process to see if these errors propogate further or are locked within QSat.
@CharlesKrop
Merge branch 'dsl/QSat' into feature/evap_subl_pdf
16ffeb0
@CharlesKrop
More clean up, first attempt at QSat function
1065cff
@CharlesKrop
Merge branch 'dsl/QSat' into feature/evap_subl_pdf
37209b9
@CharlesKrop
Working QSat function. QSat class can still be called outside of sten…
76b6ec5 
…cil to calculate QSat for entire field, or function can be called from within the stencil to calculate QSat at individual points. To use function, the QSat class must be initialized before stencil call and the tables must be passed down to the function as an input.
@CharlesKrop
Functional find_klcl port. Verifies at all but 2 points. Two failed c…
8b4bd65 
…ells are believed to be due to errors in QSat.
@CharlesKrop
Minor change for improved DQSAT functionality
fdbf8aa
@CharlesKrop
Merge branch 'dsl/QSat' into feature/evap_subl_pdf
4957707
@CharlesKrop
Minor change for improved DQSAT functionality
035f1a9
@CharlesKrop
Merge branch 'dsl/QSat' into feature/evap_subl_pdf
509884d
@CharlesKrop
Reorganization of functions/stencils from evap_subl_pdf loop to new d…
63e1ed2 
…esign that (should) work for the full GFDL_1M module.

New stencil: hystpdf (in process)
New functions: pdffrac, pdfcondensate, bergeron_partition (in process)

Bergeron_partition calls GEOS_QsatLQU/ICE, which reaches into the non-table side of the QSAT world (not currently implemented, going to tackle that next).

All new additions will be tested as one once the entire hystpdf is ported.
@CharlesKrop
Two new functions: QSat_Float_Liquid and QSat_Float_Ice. These two fu…
d826f35 
…nctions are a port of QSATLQU0/QSATICE0 when UTBL is false.

Notable difference from QSat_Float: QSat_Float features a smooth transition from ice to liquid water (based on the TMIX parameter) while these two functions have a hard transition at 0C (should transition from calling one to the other).

UNTESTED FOR NOW, NO EASILY ACCESSABLE TEST CASE
@CharlesKrop
Merge commit 'd826f3590a3f5135dddf8a20aa4083fa1511a333' into feature/…
f41b979 
…evap_subl_pdf
@CharlesKrop
Completed (but untested) hystpdf. Lots of problems compiling the sten…
1bc2787 
…cil.
@CharlesKrop
Tiny little bugfix fro QSat_Float_Liquid and QSat_Float_Ice
5aa9b48
@CharlesKrop
hystpdf compiles, few fixes to deal with various gt4py/ndsl related e…
0d3a43e 
…rrors/workarounds
@CharlesKrop
Functional, verified evap_subl_pdf loop.
9591abd 
Moved find_klcl into new misc_unused directory

Pre-commit run, fails in one spot b/c one comment is "too long"
@CharlesKrop CharlesKrop requested review from a team as code owners September 26, 2024 18:32
@FlorianDeconinck FlorianDeconinck changed the title Feature/evap subl pdf [NDSL] Feature/evap subl pdf Sep 26, 2024
@FlorianDeconinck FlorianDeconinck added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 26, 2024
FlorianDeconinck
FlorianDeconinck requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good push!

Let's reshape things

FlorianDeconinck
FlorianDeconinck requested changes Sep 27, 2024
View reviewed changes
CharlesKrop and others added 2 commits September 27, 2024 12:55
@CharlesKrop @FlorianDeconinck
Update GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSmoist_GridComp/pyMo…
04af119 
…ist/pyMoist/GFDL_1M/GFDL_1M.py

Co-authored-by: Florian Deconinck <deconinck.florian@gmail.com>
@CharlesKrop
More changes for the PR
4545264
twicki
twicki reviewed Oct 4, 2024
View reviewed changes
Copy link

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few open points to discuss still

@CharlesKrop
Changes per Tobias' comments less a proper variable naming scheme and…
3ba1a48 
… implementation of new k-level feature. Will rename after k-level feature is implemented, want to remain true to fortran until development is finished for easier tracking.
@CharlesKrop
Couple more changes based on Florian & Tobias comments. find_klcl rem…
f5b88ca 
…oved b/c it is unfinished and unused. will be recreated later on when it is needed
FlorianDeconinck
FlorianDeconinck approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small edits and we can merge

@FlorianDeconinck FlorianDeconinck merged commit 254a69c into dsl/develop Oct 11, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianDeconinck FlorianDeconinck FlorianDeconinck approved these changes

@twicki twicki Awaiting requested review from twicki

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CharlesKrop @FlorianDeconinck @twicki