Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix f32 calculation for QSat tables #1007

Merged

Conversation

FlorianDeconinck
Copy link
Collaborator

NetCDF table method has been removed, exact calculation only remains.

Florian Deconinck added 2 commits September 25, 2024 16:24
Remove NetCDF table method (exact only remains)
@FlorianDeconinck FlorianDeconinck requested review from a team as code owners September 25, 2024 20:33
@FlorianDeconinck FlorianDeconinck added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 25, 2024
Copy link

@katrinafandrich katrinafandrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Ready to merge.

Florian Deconinck added 2 commits September 26, 2024 11:18
Turn trigger to externals for stencil version of QSat
@FlorianDeconinck FlorianDeconinck merged commit 4ab2041 into GEOS-ESM:dsl/develop Sep 26, 2024
3 checks passed
@FlorianDeconinck FlorianDeconinck deleted the dsl/fix/QSat_Exact branch September 26, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants