Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use specific MOM6 Resolutions #542

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Use specific MOM6 Resolutions #542

merged 5 commits into from
Nov 27, 2023

Conversation

mathomp4
Copy link
Member

Per @sanAkel, MOM6 has "fixed" layouts per this table. This PR hardcodes that info into the setup scripts to allow only those setups.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 22, 2023
@mathomp4 mathomp4 requested a review from sanAkel November 22, 2023 14:38
sanAkel
sanAkel reviewed Nov 22, 2023
View reviewed changes
sanAkel
sanAkel approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@sanAkel sanAkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mathomp4

@sanAkel sanAkel mentioned this pull request Nov 22, 2023
Merged
@mathomp4 mathomp4 marked this pull request as ready for review November 22, 2023 17:27
@mathomp4 mathomp4 requested a review from a team as a code owner November 22, 2023 17:27
@sanAkel
Copy link
Collaborator

sanAkel commented Nov 22, 2023

@mathomp4, @sdrabenh,

  1. I followed @mathomp4's instructions and updated to use this branch and rebuilt.
  2. Set up my 3 experiments from scratch - all good with set up.
  3. I ran those 3 experiments for 6 hours - all run fine.

We do need this PR from ocean as well.

@mathomp4
Copy link
Member Author

@mathomp4, @sdrabenh,

  1. I followed @mathomp4's instructions and updated to use this branch and rebuilt.
  2. Set up my 3 experiments from scratch - all good with set up.
  3. I ran those 3 experiments for 6 hours - all run fine.

We do need this PR from ocean as well.

Okay. Next up, I need to fix up my scripting so that it can handle the missing questions...

@sanAkel
Copy link
Collaborator

sanAkel commented Nov 27, 2023

@mathomp4, @sdrabenh,

  1. I followed @mathomp4's instructions and updated to use this branch and rebuilt.
  1. Set up my 3 experiments from scratch - all good with set up.
  1. I ran those 3 experiments for 6 hours - all run fine.

We do need this PR from ocean as well.

Okay. Next up, I need to fix up my scripting so that it can handle the missing questions...

@mathomp4 When ready me know. Thanks for merging companion PRs.

@mathomp4
Copy link
Member Author

Dang it. Still not working.

@mathomp4 mathomp4 merged commit 966db1e into feature/sanAkel/fix_update_coupled-set-up Nov 27, 2023
@mathomp4 mathomp4 deleted the feature/mathomp4/specific-mom6 branch November 27, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanAkel sanAkel sanAkel approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @sanAkel