Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to allow testing of ExtData2G #331

Merged
merged 8 commits into from
Jul 11, 2022

Conversation

bena-nasa
Copy link
Collaborator

This PR updates gcm_setup and gcm_run.j so that if ExtData2G is turned on, it can be used for testing purposes. Now that it appears there is traction in the other repos to bring in the new yaml files it was time to make this PR.

@bena-nasa bena-nasa added enhancement New feature or request 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels May 26, 2022
@bena-nasa bena-nasa requested a review from a team as a code owner May 26, 2022 15:23
@bena-nasa bena-nasa requested a review from sdrabenh May 26, 2022 15:27
@bena-nasa bena-nasa added the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label May 26, 2022
@bena-nasa bena-nasa requested a review from a team as a code owner May 31, 2022 20:49
tclune
tclune previously approved these changes May 31, 2022
@bena-nasa bena-nasa removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label May 31, 2022
if( $EXTDATA2G_TRUE == 1 ) then

$GEOSBIN/construct_extdata_yaml_list.py GEOS_ChemGridComp.rc
touch ExtData.rc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bena-nasa Should this be touch extdata.yaml?

Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@sdrabenh sdrabenh merged commit 03c57a2 into develop Jul 11, 2022
@sdrabenh sdrabenh deleted the feature/bmauer/add_extdata2g_files branch July 11, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants