Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Intel Compiler Issue #47

Closed
wants to merge 1 commit into from

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jul 7, 2021

This PR fixes a weird bug seen when the GEOSadas is advanced to the latest sub-components (see GEOS-ESM/GEOSadas#103).

For reasons yet unknown, when the sub-components are advanced, geos_StateIO.F90 fails with errors like:

/discover/swdev/mathomp4/Models/GEOSadas-5_29_0-with-Bills/GEOSadas/src/Components/@GEOSana_GridComp/GEOSaana_GridComp/GEOSgsi_Coupler/geos_StateIO.F90(1442): error #6404: This name does not
 have a type, and must have an explicit type.   [SG]
      do j=1,sg%lon2
-------------^

Note: This seems to happen with both Intel 19.1.3 and Intel 2021.2. It is unknown if GNU would show an issue as the GNU compilers cannot as yet compile the GEOSadas.

The fix in this PR (by @rtodling) is to make some internal procedures external.

@mathomp4 mathomp4 added bugfix 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jul 7, 2021
@mathomp4 mathomp4 requested a review from a team as a code owner July 7, 2021 13:25
@rtodling
Copy link
Contributor

The fix for this is now under:

feature/rtodling/change_due2odd_compiler_bug

@mathomp4
Copy link
Member Author

Closed in favor of #48

@mathomp4 mathomp4 closed this Jul 21, 2021
@mathomp4 mathomp4 deleted the bugfix/mathomp4/geos-state-compiler-error branch July 21, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants