Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS Environment Variables env() #4555

Merged
merged 4 commits into from
Oct 18, 2018
Merged

Conversation

ausi
Copy link
Contributor

@ausi ausi commented Oct 16, 2018

See #3787.

env() is supported since Safari 11, Chrome 69, Opera 56.

@ausi ausi mentioned this pull request Oct 16, 2018
@Malvoz
Copy link
Contributor

Malvoz commented Oct 16, 2018

Want to add MS Edge feature suggestion to that?
https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/34589707-css-environment-variables

Should probably extend keywords to "CSS variables" here aswell.

@ausi
Copy link
Contributor Author

ausi commented Oct 16, 2018

@Malvoz done.

@Malvoz
Copy link
Contributor

Malvoz commented Oct 16, 2018

Thanks, I have further requests on that though - if a user searches explicitly for e.g. "css env()" or "css variables" this would not show with the current keywords:

env,safe-area-inset,constant,variables.

Can I bother you with an updated list on that?

css env(),constant(),css variables,safe-area-inset-top,safe-area-inset-right,safe-area-inset-bottom,safe-area-left.

I think it is a tad bit overkill with the safe-area-*, but users will find what they're looking for.

@ausi
Copy link
Contributor Author

ausi commented Oct 17, 2018

@Malvoz done.

@Fyrd Fyrd merged commit ade18e5 into Fyrd:master Oct 18, 2018
@Fyrd
Copy link
Owner

Fyrd commented Oct 18, 2018

Thanks!

@kiding
Copy link
Contributor

kiding commented Oct 30, 2018


Since there is no pending review, I believe shown should be true unless there is any particular reason.

EDIT: Now fixed! #3787 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants