remove_nonterminal_branches
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
reviewed
Jan 15, 2025
ldp/data_structures.py
Outdated
| @@ -336,6 +336,25 @@ def compute_advantages(self) -> None: | |||
| # See docstring for explanation. | |||
| # step.metadata["advantage"] = step.value - state_values[parent_id] | |||
|
|
|||
| def remove_nonterminal_branches(self) -> TransitionTree: | |||
| """Creates a new tree with only branches that end in terminal states.""" | |||
There was a problem hiding this comment.
Can you add a comment stating failure is not considered here
There was a problem hiding this comment.
Clarified done=True. Technically one could write a pathological environment in which both step.done and step.failed are true, and we'd include that branch in this method. So I don't want to claim we exclude failures.
jamesbraza
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A method to create a tree with only terminal branches