Removed arbitrary_types_allowed=True from MultipleChoiceQuestion via custom Pydantic serializer/validator
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidnarayanan
approved these changes
Jan 21, 2025
| @@ -211,6 +212,37 @@ async def extract_answer( | |||
| return None | |||
|
|
|||
|
|
|||
| class RandomAnnotation: | |||
There was a problem hiding this comment.
Out of curiosity, why go this route instead of field_serializer/validator?
There was a problem hiding this comment.
Yeah good question, it's for reusability. I can easily import/reuse RandomAnnotation across many different BaseModel, whereas field_serializer/validator are class-specific and not reusable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#177 added
random.Randomsupport, but also addedarbitrary_types_allowed=TruetoMultipleChoiceQuestion. I didn't like thatarbitrary_types_allowed, so I tapped into Pydantic v2's custom validator/serializer logic to allow serialization ofrandom.Random.