Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Always on top #4

Merged
merged 5 commits into from
Nov 30, 2021
Merged

feat: Always on top #4

merged 5 commits into from
Nov 30, 2021

Conversation

sumeshir26
Copy link
Member

@im-coder-lg Can you test always on top on Zorin?
Also, does zorin have dark mode titlebars?

@sumeshir26 sumeshir26 self-assigned this Nov 26, 2021
@im-coder-lg
Copy link
Member

Well, still not on Zorin. Having bad health(not too bad tho) that's why you see fewer commits from me+not on the upgrade lane. I have to give this PC for repair too, add some more memory or a better mic and wait for a move on from Windows, but back to the topic, Zorin does have dark mode title bars. On watching many videos on Zorin OS, I noticed that whenever you switch to dark mode, the taskbar, Zorin Appearances(where you change your theme, appearance, etc) changes, everything does. Zorin apps that are definitely not browsers have a dark title bar with window control. The title is kinda centred and if you need more help on that, you can check GTK3+ theming(minimalistic) since Zorin uses Gnome as the DE. That might help you with the design.
I'm not feeling so well, I have a really disturbing cough so I haven't given this computer for OS reinstallation yet. Can't run a VM due to my limitations, but I can maybe help you with the look and feel of Zorin.
Also, whenever you switch themes, the icons kind of move, so can you check that?

@sumeshir26
Copy link
Member Author

sumeshir26 commented Nov 26, 2021

Also, whenever you switch themes, the icons kind of move, so can you check that?

See this rdbende/Sun-Valley-ttk-theme#6
@im-coder-lg

@sumeshir26 sumeshir26 merged commit 313a70d into master Nov 30, 2021
@sumeshir26 sumeshir26 deleted the always-on-top branch November 30, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants