Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About window #33

Merged
merged 4 commits into from
Jan 6, 2022
Merged

About window #33

merged 4 commits into from
Jan 6, 2022

Conversation

not-nef
Copy link
Member

@not-nef not-nef commented Jan 4, 2022

Its done. And also: @sumeshir26 i fixed your „improvements“. You should test your changes in the future.

@not-nef
Copy link
Member Author

not-nef commented Jan 4, 2022

I request merging.

@im-coder-lg
Copy link
Member

Testing this bro!

Copy link
Member

@im-coder-lg im-coder-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Don't merge this immediately though.

Copy link
Member

@im-coder-lg im-coder-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Don't merge this immediately though.

@not-nef
Copy link
Member Author

not-nef commented Jan 4, 2022

LGTM! Don't merge this immediately though.

ofc, still need sumeshirs review, but cool that you like it

@im-coder-lg
Copy link
Member

Wait why's there no checks?

@not-nef
Copy link
Member Author

not-nef commented Jan 4, 2022

there were checks

@not-nef
Copy link
Member Author

not-nef commented Jan 4, 2022

image

@not-nef
Copy link
Member Author

not-nef commented Jan 4, 2022

or did you mean any other checks?

@not-nef
Copy link
Member Author

not-nef commented Jan 4, 2022

Ah, you meant the build checks right? no idea why it didnt do any. but i think it should work since the script runs with no problems.

@im-coder-lg
Copy link
Member

im-coder-lg commented Jan 4, 2022

Ah, you meant the build checks right?

Yeah. No wonder why it didn't load here... Oh no you reminded me, I need to make a Docusaurus check lmao forgot that! Making that tomorrow!

@sumeshir26
Copy link
Member

@not-nef Can I get collaborator access for your new fork?

@im-coder-lg
Copy link
Member

This works, I can guarantee that.

@im-coder-lg
Copy link
Member

Although, TimerX is getting much slower with more code. I have observed this, maybe that's why I objected to merging configurator code.

@sumeshir26
Copy link
Member

@im-coder-lg Where is it getting slower?
What are your pc's Specs?

@im-coder-lg
Copy link
Member

im-coder-lg commented Jan 5, 2022

Where is it getting slower?

Whenever I launch it from source.

What are your PC's Specs?

Intel Core i3, 4 GB RAM, an HDD of Windows and an SSD of my folders. Ultra-fast legendary speed for me.

@not-nef
Copy link
Member Author

not-nef commented Jan 5, 2022

Well no offense but thats pretty bad. And if you have an Ssd, why dont you use it for windows?

@not-nef
Copy link
Member Author

not-nef commented Jan 5, 2022

@not-nef Can I get collaborator access for your new fork?

what, why?

@im-coder-lg
Copy link
Member

Well no offense but thats pretty bad. And if you have an Ssd, why dont you use it for windows?

None taken. I have another computer but since I filled it up with my phone backups, I'll have to backup the important parts and reinstall Windows. It's 8 GB, but I like my 4 GB one. And speaking of the SSD, I didn't install it, it came preinstalled so idk which is Windows lol.

@im-coder-lg
Copy link
Member

Oh, forgot, it's Core i5, noticed it while running my Windows XP VM.

@not-nef
Copy link
Member Author

not-nef commented Jan 5, 2022

cool, i also have an i5

@sumeshir26
Copy link
Member

Mee to(10th Gen Core i5, 8GB Ram)

@sumeshir26
Copy link
Member

i need you to give me collaborator access so I can checkout and commit using the Github CLI

@im-coder-lg
Copy link
Member

im-coder-lg commented Jan 5, 2022

Mee to(10th Gen Core i5, 8GB Ram)

I have an older one though but it's faster, just what I want.

@not-nef
Copy link
Member Author

not-nef commented Jan 5, 2022

i need you to give me collaborator access so I can checkout and commit using the Github CLI

ooke

@not-nef
Copy link
Member Author

not-nef commented Jan 5, 2022

done

@im-coder-lg
Copy link
Member

Totally complete?

@not-nef
Copy link
Member Author

not-nef commented Jan 5, 2022

yup

@not-nef
Copy link
Member Author

not-nef commented Jan 5, 2022

@sumeshir26 review pls

@not-nef
Copy link
Member Author

not-nef commented Jan 5, 2022

Although, TimerX is getting much slower with more code. I have observed this, maybe that's why I objected to merging configurator code.

Try compiling it (runs faster)

@not-nef
Copy link
Member Author

not-nef commented Jan 5, 2022

atleast for me

@sumeshir26 sumeshir26 merged commit 43f45b9 into Futura-Py:master Jan 6, 2022
@not-nef not-nef deleted the About-Window branch January 6, 2022 09:27
@not-nef
Copy link
Member Author

not-nef commented Jan 6, 2022

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants