-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About window #33
About window #33
Conversation
I request merging. |
Testing this bro! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Don't merge this immediately though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Don't merge this immediately though.
ofc, still need sumeshirs review, but cool that you like it |
Wait why's there no checks? |
there were checks |
or did you mean any other checks? |
Ah, you meant the build checks right? no idea why it didnt do any. but i think it should work since the script runs with no problems. |
Yeah. No wonder why it didn't load here... Oh no you reminded me, I need to make a Docusaurus check lmao forgot that! Making that tomorrow! |
@not-nef Can I get collaborator access for your new fork? |
This works, I can guarantee that. |
Although, TimerX is getting much slower with more code. I have observed this, maybe that's why I objected to merging configurator code. |
@im-coder-lg Where is it getting slower? |
Whenever I launch it from source.
Intel Core i3, 4 GB RAM, an HDD of Windows and an SSD of my folders. Ultra-fast legendary speed for me. |
Well no offense but thats pretty bad. And if you have an Ssd, why dont you use it for windows? |
what, why? |
None taken. I have another computer but since I filled it up with my phone backups, I'll have to backup the important parts and reinstall Windows. It's 8 GB, but I like my 4 GB one. And speaking of the SSD, I didn't install it, it came preinstalled so idk which is Windows lol. |
Oh, forgot, it's Core i5, noticed it while running my Windows XP VM. |
cool, i also have an i5 |
Mee to(10th Gen Core i5, 8GB Ram) |
i need you to give me collaborator access so I can checkout and commit using the Github CLI |
I have an older one though but it's faster, just what I want. |
ooke |
done |
Totally complete? |
yup |
@sumeshir26 review pls |
Try compiling it (runs faster) |
atleast for me |
🎉 |
Its done. And also: @sumeshir26 i fixed your „improvements“. You should test your changes in the future.