feat(including bugs): minor changes that increases functionality

[im-coder-lg]

Hi @sumeshir26,

This is a really great project! Although it has a few glitches(listed below), it's a chance for me to learn some new things too. So, after long research(and switching between computers), I have made a series of minor changes in the source file(main.py) and removed the spec listing from the .gitignore(later on that). I have also generated a newer executable with the TimerX icon you provided in the assets directory. And, I think you don't need the setup.py file anymore since PyInstaller can build everything for you(more on that later).

Now, the glitches are as follows:

1. You need to click the Play button twice to start the timer.
2. The timer takes one second to start and the rest 5 seconds as countdown, so reducing the extra second seems like a good idea.
3. This has been happening for me, but whenever the timer ends, I get a driver error(it doesn't play the audio but my driver's all cool, I can see YT videos, and hear audio content). Does the same happen for you too?

Next, why did I remove the spec file from the .gitignore?

I think you used Pyinstaller the first time you built it. And there is an additional tool with PyInstaller called pyi-makespec, which generates SPEC files for making building the app easier. Basically, clone the repo, get PyInstaller, and run this: pyinstaller main.spec in the root. You get an absolutely smashing executable with the TimerX logo(put it in the root dir to run that, so that it will detect the assets), and it has no consoles open(although, a console might open during errors like running the app from the dist dir due to assets).

So, I'm done here. I need your opinions on this, and also about the driver error I mentioned above.

[sumeshir26]

@im-coder-lg no, I do not get any driver errors🤔🤔

[sumeshir26]

❤️Awsome work! Do you want me to merge?

[im-coder-lg]

❤️Awesome work! Do you want me to merge?

Well not yet because I am still analyzing the code... The icon seems zoomed in when it's a plain exe... Need to check that, and can you try sharing the original TimerX icon file? Maybe I can try making it into an .ico file and test with that...

@im-coder-lg no, I do not get any driver errors🤔🤔

As expected because you run Windows 11 which has advanced drivers, so I think this could be the time to upgrade to Linux soon... But other than that, great! I just need to find how to make macOS builds and add that here so that Mac users don't need to feel left alone or also they won't need to install Wine(compatibility layer) to run TimerX... Will see that tomorrow.

[im-coder-lg]

Do you know anyone who has a Mac @sumeshir26? Maybe you can test TimerX's Mac build on that. It seems that you can use py2exe as well as PyInstaller, so if we could get a hand at macOS, we could try building TimerX from the terminal. If it succeeds, we are good on a Mac app file.

[im-coder-lg]

The Linux build is failing. I have a Raspberry Pi running Raspbian Buster(Debian 10 for Raspberry Pi) and tried building it. The build started well, but the file doesn't execute. I mean, in Geany, if you execute main.py, it'll throw up an error saying that assets/logo.ico isn't found. Linux doesn't use .ico files, so we need to find a proper icon file for Linux. Think macOS has this same error?

[im-coder-lg]

The video is called an Asciicast, used for showing console logs as videos. On the Pi, I have configured it to show a Neofetch result at the beginning to show the OS. That's proof it's Raspbian. After that, I changed the directory to TimerX's dir, showed my branch(fork not the base TimerX), and entered python3 main.py and I ended up with the error. Can you try sharing the original logo image? Maybe I can make macOS and Linux icons from that.

[sumeshir26]

@im-coder-lg the original logo is in the assets/images dir

[im-coder-lg]

We got some issues.

1. The .ico code works only on Windows, which means we need different files+icons for each OS.
2. The logo doesn't work as a JPEG or as a JPG, it works as a PNG, and the PNG I generated was low-quality. Making an icon is the best idea.
3. Your about window's icon doesn't work due to the JPEG error, so we need different icons and different files for each OS, which makes 3 main.py files, 3 configurator.py files and 3 main.spec files, which squares the file load.

We need a solution to this soon. I could change the About page's icon to a bitmap icon(.ico) but Macs use .icns and Linux uses .icon(I guess). How can we fix this?

[im-coder-lg]

I just hopped onto the GAUDC project(that gave me a lot of ideas to implement here) and saw the app/res/icons folder and I saw a horde of icons! And as expected, there was an ICNS. So, Linux seems to have PNGs or SVG images, but you need an ICNS for Mac. So, we hit something here, and maybe I could get a fresh ICNS for Mac. @sumeshir26 does Python recognize OSes? Like, if I run TimerX from source on Linux, will the file know that it runs on Linux? If it does, we could use if and elif commands to manage the icon issue. And also, if the system is neither Windows nor MacOS or Linux, it will resort to the PNG(for now). Is this possible?

[im-coder-lg]

We could use this solution I found in Stack Overflow:

from sys import platform
if platform == "linux" or platform == "linux2":
    # linux
elif platform == "darwin":
    # OS X
elif platform == "win32":
    # Windows...

We also need a requirements.txt so that users get the deps like so: pip install -r rquirements.txt

[sumeshir26]

@im-coder-lg Let me add it real quick..

[im-coder-lg]

Wait what? You are adding the code? We need the icon files! An ICNS, a Linux icon file and an improved PNG(no more JPEG, it throws up an error)

[im-coder-lg]

It is hard to make an ICNS file. I have used online converters and always fail under that.

[sumeshir26]

@im-coder-lg Let me try to make a icns

[im-coder-lg]

Does py2exe support SPEC files? If they do, we could use py2xe for the generation of files and pyinstaller for modifying the SPEC file. Could that be possible?

[im-coder-lg]

Mac failed. Maybe we need to use a different build platform for Macs. What about PyInstaller?

[im-coder-lg]

@sumeshir26 jackpot. I made the ICNS using an online tool, it's on my device, uploading here now.

[im-coder-lg]

The thing is since it was made from the PNG, how'd the quality be?

[sumeshir26]

@im-coder-lg The build fails on line 63 of setup.py

[sumeshir26]

Anyway, i got the icns

[sumeshir26]

Uploding in the assets directory on your fork...

[sumeshir26]

@im-coder-lg I'll try after I get the dark mode working

[im-coder-lg]

The icon can be used from the Material Icons library(open-source here on GitHub).

[sumeshir26]

@im-coder-lg What icon?

[sumeshir26]

I think I will just use darkdetct to detect the system theme

[im-coder-lg]

@im-coder-lg What icon?

Dark mode toggle. If you use an icon instead of text, it'd just blend into the layout(not meaning "hide", it'd be like it belongs there). Make sure to use a lighter shade of black so that users can see things properly.

[sumeshir26]

@im-coder-lg What OS are you on?

[im-coder-lg]

Windows 7, but I am hoping to switch to Zorin OS within the next few weeks. I also have a Raspberry Pi running Raspbian Bullseye, the Linux tests I said were from that.

[sumeshir26]

@im-coder-lg Should I merge?

[sumeshir26]

Idk anyone with a mac

[im-coder-lg]

@im-coder-lg Should I merge?

Not yet

Idk anyone with a mac

Same. I hate getting a Hackintosh as a VM, so we need to make Windows and Linux builds only, till you find a person using a Mac. I know I can't find one, but I will try.

[sumeshir26]

What else do you want to add?

[sumeshir26]

@im-coder-lg

[im-coder-lg]

Sorry man, I was too busy+had headache, I will push the changes by tonight.

[sumeshir26]

@im-coder-lg No problem 😉 Get well soon…

[im-coder-lg]

@im-coder-lg No problem 😉 Get well soon…

Thanks man, got rid of them, happens, now I am ready to get the PR for merge 😀

[im-coder-lg]

Whoa. Never expected to see the fact that, once I made breaking changes to configuration.py, and thought I pushed the changes here, the PR is ready for merge.

Edit: sorry touchslip, was commenting via phone.
We need to do the next steps:

• Fix checks

• Make a successful build deployer via GH actions, since a VM'd be costly if in GCP and on a local machine, it'd be advised to not do that or it'd just slow the computer down.

• Arrange the entire codebase and fix about page.

• Make the required files to make TimerX a community-friendly repository

We must do these steps soon. The repo is still young but we must be up for 100 commits due to my commit, revert and repeat (foolishness xD) method, and periodic push. But we are ready for the next steps.

[sumeshir26]

I don’t see any changes?

[im-coder-lg]

Well because there are no changes. I thought I made some breaking changes so I asked for time.

The PR is ready for merge.