Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shellcheck URL #122

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Conversation

chaconpiza
Copy link
Member

This is the output using the outdated URL:

$ wget "https://storage.googleapis.com/shellcheck/shellcheck-$SCVERSION.linux.x86_64.tar.xz"
--2020-06-03 06:43:52--  https://storage.googleapis.com/shellcheck/shellcheck-stable.linux.x86_64.tar.xz
Resolving storage.googleapis.com (storage.googleapis.com)... 172.217.204.128, 2607:f8b0:400c:c07::80
Connecting to storage.googleapis.com (storage.googleapis.com)|172.217.204.128|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 540 [application/x-xz]
Saving to: ‘shellcheck-stable.linux.x86_64.tar.xz’
     0K                                                       100% 99.5M=0s
2020-06-03 06:43:52 (99.5 MB/s) - ‘shellcheck-stable.linux.x86_64.tar.xz’ saved [540/540]
before_install.2
0.01s$ tar --xz -xvf "shellcheck-$SCVERSION.linux.x86_64.tar.xz"
before_install.3
0.00s$ shellcheck() { "shellcheck-$SCVERSION/shellcheck" "$@"; }
0.01s$ shellcheck --version
You are downloading ShellCheck from an outdated URL!
Please update to the new URL:
https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.linux.x86_64.tar.xz
For more information, see:
https://github.com/koalaman/shellcheck/issues/1871
PS: Sorry for breaking your build :(

This is the output using the outdated URL:

```
$ wget "https://storage.googleapis.com/shellcheck/shellcheck-$SCVERSION.linux.x86_64.tar.xz"
--2020-06-03 06:43:52--  https://storage.googleapis.com/shellcheck/shellcheck-stable.linux.x86_64.tar.xz
Resolving storage.googleapis.com (storage.googleapis.com)... 172.217.204.128, 2607:f8b0:400c:c07::80
Connecting to storage.googleapis.com (storage.googleapis.com)|172.217.204.128|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 540 [application/x-xz]
Saving to: ‘shellcheck-stable.linux.x86_64.tar.xz’
     0K                                                       100% 99.5M=0s
2020-06-03 06:43:52 (99.5 MB/s) - ‘shellcheck-stable.linux.x86_64.tar.xz’ saved [540/540]
before_install.2
0.01s$ tar --xz -xvf "shellcheck-$SCVERSION.linux.x86_64.tar.xz"
before_install.3
0.00s$ shellcheck() { "shellcheck-$SCVERSION/shellcheck" "$@"; }
0.01s$ shellcheck --version
You are downloading ShellCheck from an outdated URL!
Please update to the new URL:
https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.linux.x86_64.tar.xz
For more information, see:
koalaman/shellcheck#1871
PS: Sorry for breaking your build :(
```
@chaconpiza chaconpiza requested a review from adriancz June 3, 2020 12:53
@adriancz adriancz merged commit aa0ef4b into master Jun 3, 2020
@adriancz adriancz deleted the martinchacon-update-shellcheck-url branch September 14, 2020 13:54
@adriancz adriancz restored the martinchacon-update-shellcheck-url branch September 14, 2020 13:54
@adriancz adriancz deleted the martinchacon-update-shellcheck-url branch September 14, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants