Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default Forc manifest #973

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Update default Forc manifest #973

merged 1 commit into from
Mar 20, 2022

Conversation

adlerjohn
Copy link
Contributor

  1. Remove core as a dependency since 100% (rounded) of users will not use core directly.
  2. Use https instead of http.

@adlerjohn
Update default Forc manifest
a04a11d 
1. Remove `core` as a dependency since 100% (rounded) of users will not use `core` directly.
1. Use `https` instead of `http`.
@adlerjohn adlerjohn self-assigned this Mar 20, 2022
mitchmindtree
mitchmindtree approved these changes Mar 20, 2022
View reviewed changes
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@adlerjohn adlerjohn merged commit 0281466 into master Mar 20, 2022
@adlerjohn adlerjohn deleted the adlerjohn/default-forc-manifest-deps branch March 20, 2022 13:47
@mitchmindtree mitchmindtree mentioned this pull request Mar 22, 2022
Closed
@adlerjohn adlerjohn mentioned this pull request Apr 4, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@mitchmindtree mitchmindtree mitchmindtree approved these changes

@sezna sezna Awaiting requested review from sezna

@mohammadfawaz mohammadfawaz Awaiting requested review from mohammadfawaz

Assignees

@adlerjohn adlerjohn

Labels
code quality forc
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adlerjohn @JoshuaBatty @mitchmindtree