-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initial version of the formatter #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my IDE, the indent size seems to beThis was an IDE config issue on my end.2
, despite being configured to be4
? Can you default it to 4 for the time being, until we have a.forcfmt.toml
file.- In a future PR (or maybe this one, actually), add a
forc fmt
command to run formatting without having to use an IDE. (Command-line formatter #80) - Bug: running formatting seems to be semantically destructive. If I write some random invalid syntax (e.g. change a
bool
toaool
, instead of showing a compile error, the formatter clobbers the file and writes the latest valid file. This needs to be fixed in this PR.
@adlerjohn for 1. that is really weird, I am using IDE settings directly so whatever is set in your IDE Settings that is the indentation that's used in the formatter, as for other two things, I'll try to add/fix by tomorrow |
@leviathanbeak well (1) will go away once we have a |
@adlerjohn I have fixed the sync bug you reported |
No description provided.