Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump git2-rs version to 0.17.2 and required libgit2 to v1.6.4 #4717

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Jun 29, 2023

Description

Bumps git2-rs to 0.17.2, so that forc requires libgit2 v1.6.4 to compile. This is needed as fuel.nix flake is in a deadlock; sysinfo dependency introduced in #4564 requires us to bump macos sdk versions while libgit2 v0.1.5.1 fails to compile with the bumped SDK version.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp self-assigned this Jun 29, 2023
@kayagokalp kayagokalp force-pushed the kayagokalp/bump-git2 branch from 03ed9cb to 55a6911 Compare June 29, 2023 15:35
@kayagokalp kayagokalp requested a review from a team June 29, 2023 15:42
@kayagokalp kayagokalp marked this pull request as ready for review June 29, 2023 15:42
@kayagokalp kayagokalp requested a review from a team June 29, 2023 15:42
@kayagokalp kayagokalp enabled auto-merge (squash) June 29, 2023 15:42
@kayagokalp kayagokalp merged commit 5d8d8ed into master Jun 29, 2023
@kayagokalp kayagokalp deleted the kayagokalp/bump-git2 branch June 29, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants