fix contract caller types #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otrho
approved these changes
Sep 14, 2022
|
Thanks Alex! Does this also address #1261 (comment)? If so, then do you mind adding some tests for that use case? |
|
Unfortunately, you still can't return a caller as a type from a function. That functionality is currently broken. I could fix that in a follow-on, but I think it will get fixed by introducing the |
mohammadfawaz
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some incorrect type unification and closes #1261. Really this was just the result of some behavior being untested, so it regressed over time. The type engine code for unifying contract callers had some typos.
I've disabled the
contract_caller_as_typetest, as this breaks that functionality, but that functionality is very much a special case and will be enabled by #2463 and a rework of theContracttype -- this should at least unblock the DAO contract and the berlin workshop.