Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdlib Vec #1118

Merged
merged 39 commits into from
Jun 17, 2022
Merged

stdlib Vec #1118

merged 39 commits into from
Jun 17, 2022

Conversation

adlerjohn
Copy link
Contributor

@adlerjohn adlerjohn commented Mar 31, 2022 •
edited
Loading

@adlerjohn adlerjohn added enhancement New feature or request lib: std Standard library labels Mar 31, 2022
@adlerjohn adlerjohn self-assigned this Mar 31, 2022
mitchmindtree
mitchmindtree reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh just noticed this is a draft! Leaving the comment anyway just in case

This was referenced Apr 4, 2022
Closed
Closed
This was referenced May 27, 2022
Closed
Closed
@emilyaherbert emilyaherbert mentioned this pull request May 28, 2022
Merged
@adlerjohn adlerjohn mentioned this pull request May 28, 2022
Closed
Braqzen
Braqzen reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@Braqzen Braqzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks

mohammadfawaz and others added 5 commits June 16, 2022 14:17
@mohammadfawaz @Braqzen
Update sway-lib-std/src/vec.sw
c5daa7a 
Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
@mohammadfawaz @Braqzen
Update sway-lib-std/src/vec.sw
a9bbfa1 
Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
@mohammadfawaz
first wave of comments
0ba4ae4
@mohammadfawaz @Braqzen
Update test/src/e2e_vm_tests/test_programs/should_pass/stdlib/vec/src…
a345ee1 
…/main.sw

Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
@mohammadfawaz @Braqzen
Update test/src/e2e_vm_tests/test_programs/should_pass/stdlib/vec/src…
1c4971d 
…/main.sw

Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
@digorithm digorithm mentioned this pull request Jun 16, 2022
Closed
7 tasks
adlerjohn
adlerjohn commented Jun 16, 2022
View reviewed changes
@mohammadfawaz mohammadfawaz mentioned this pull request Jun 16, 2022
Merged
@adlerjohn
Copy link
Contributor Author

adlerjohn commented Jun 16, 2022 •
edited
Loading

Blocked by #2013. @mohammadfawaz maybe re-target this PR on top of #2013? Or just wait I guess, since it's already approved.

AlicanC
AlicanC reviewed Jun 16, 2022
View reviewed changes
adlerjohn
adlerjohn commented Jun 16, 2022
View reviewed changes
Copy link
Contributor Author

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but can't approve since I'm the OP. @AlicanC's memory functions are a beauty. Can't believe this is now implementable without a single line of asm.

@AlicanC AlicanC self-requested a review June 16, 2022 21:33
sezna
sezna approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests give me much faith

@mohammadfawaz
Copy link
Contributor

I will wait for @otrho to also take a look as the current code owner of the standard library.

@emilyaherbert emilyaherbert self-requested a review June 16, 2022 23:08
emilyaherbert
emilyaherbert approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@emilyaherbert emilyaherbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@adlerjohn adlerjohn merged commit 422c9ca into master Jun 17, 2022
@adlerjohn adlerjohn deleted the adlerjohn/stdlib-vec branch June 17, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadfawaz mohammadfawaz mohammadfawaz left review comments

@Braqzen Braqzen Braqzen left review comments

@otrho otrho otrho approved these changes

@AlicanC AlicanC AlicanC approved these changes

@sezna sezna sezna approved these changes

@emilyaherbert emilyaherbert emilyaherbert approved these changes

@nfurfaro nfurfaro Awaiting requested review from nfurfaro

@mitchmindtree mitchmindtree Awaiting requested review from mitchmindtree

Assignees

@adlerjohn adlerjohn

Labels
enhancement New feature or request lib: std Standard library
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal to add equivalent of the Vec type
8 participants
@adlerjohn @mohammadfawaz @otrho @AlicanC @mitchmindtree @sezna @emilyaherbert @Braqzen