code review feedback

core_lang/src/asm_generation/finalized_asm.rs

@@ -66,7 +66,6 @@ fn to_bytecode<'sc>(
                 half_word_ix += 2;
             }
             Either::Left(mut op) => {
-                println!("Serializing {:?}", op);
                 op.read(&mut buf[half_word_ix * 4..])
                     .expect("Failed to write to in-memory buffer.");
                 half_word_ix += 1;

core_lang/src/parse_tree/literal.rs

@@ -19,6 +19,7 @@ pub enum Literal<'sc> {
 }
 
 impl<'sc> Literal<'sc> {
+    #[allow(dead_code)]
     pub(crate) fn as_type(&self) -> ResolvedType<'sc> {
         use Literal::*;
         match self {

test_suite/src/e2e_vm_tests/harness.rs

@@ -5,7 +5,7 @@ use fuel_vm_rust::interpreter::Interpreter;
 
 /// Very basic check that code does indeed run in the VM.
 /// `true` if it does, `false` if not.
-pub(crate) fn runs_in_vm(file_name: &str) -> bool {
+pub(crate) fn runs_in_vm(file_name: &str) {
     let script = compile_to_bytes(file_name);
     let gas_price = 10;
     let gas_limit = 10000;
@@ -26,13 +26,7 @@ pub(crate) fn runs_in_vm(file_name: &str) -> bool {
     );
     let block_height = (u32::MAX >> 1) as u64;
     tx.validate(block_height).unwrap();
-    match Interpreter::execute_tx(tx) {
-        Ok(_) => true,
-        Err(e) => {
-            println!("Failed: {}", e);
-            false
-        }
-    }
+    Interpreter::execute_tx(tx).unwrap();
 }
 
 /// Returns `true` if a file compiled without any errors or warnings,

test_suite/src/e2e_vm_tests/mod.rs

@@ -2,13 +2,7 @@ mod harness;
 
 pub fn run() {
     let project_names = vec!["script_1", "script_2", "script_3"];
-    assert!(project_names.into_iter().all(|name| {
-        let result = crate::e2e_vm_tests::harness::runs_in_vm(name);
-        if !result {
-            println!("E2E Failure: {} should have run in the VM.", name);
-            false
-        } else {
-            true
-        }
-    }));
+    project_names.into_iter().for_each(|name| {
+        crate::e2e_vm_tests::harness::runs_in_vm(name);
+    });
 }