Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage to highlighted words #50

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Conversation

nfurfaro
Copy link
Contributor

@nfurfaro nfurfaro commented Jun 3, 2022

This PR aims to add the storage keyword to the list of highlighted words.
I'm not familiar with the code in this repo, so not sure if I need to do more or how to test my changes.
closes #46

@nfurfaro nfurfaro added the enhancement New feature or request label Jun 3, 2022
@nfurfaro nfurfaro requested a review from eureka-cpu June 3, 2022 12:05
@nfurfaro nfurfaro self-assigned this Jun 3, 2022
@adlerjohn adlerjohn requested review from JoshuaBatty and sdankel and removed request for eureka-cpu June 3, 2022 21:33
@nfurfaro nfurfaro requested a review from eureka-cpu June 4, 2022 15:48
@eureka-cpu
Copy link
Contributor

eureka-cpu commented Jun 4, 2022

  1. to test for your branch read this: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#packaging-extensions

  2. the context in which this works is only if you add a name after the storage keyword. Essentially just need to allow the keyword itself, but the current state is that it's being treated the same as a struct or enum which will have a name after the keyword

This works:

storage Name {
    field: ...,
}

This doesn't:

storage {
    field: ...,
}

@eureka-cpu eureka-cpu requested a review from adlerjohn June 4, 2022 21:17
syntaxes/sway.tmLanguage.json Outdated Show resolved Hide resolved
@nfurfaro nfurfaro merged commit 674cbcb into master Jun 6, 2022
@nfurfaro nfurfaro deleted the furnic/46-highlight-storage branch June 6, 2022 23:47
sdankel pushed a commit that referenced this pull request Apr 17, 2024
* feat: add storage to highlighted words

* Revert "feat: add storage to highlighted words"

This reverts commit 6fac165.

* feat: add storage keyword to highlighted words

* fix: remove where branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

'storage' keyword should be highlighted in vs-code
4 participants