Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: prevent implicit asset burn #3540

Merged
merged 37 commits into from
Jan 10, 2025
Merged
Changes from 2 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
8b58f28
feat: added test for feature
petertonysmith94 Jan 3, 2025
0ea3d8f
feat: added guards against illicit asset burns
petertonysmith94 Jan 3, 2025
a33ec72
chore: docs
petertonysmith94 Jan 3, 2025
69e480f
chore: changeset
petertonysmith94 Jan 3, 2025
5e053b3
chore: removed test.only
petertonysmith94 Jan 6, 2025
61da932
chore: finalize the PR
petertonysmith94 Jan 6, 2025
987221f
Merge branch 'master' into ps/feat/prevent-illicit-burn
petertonysmith94 Jan 6, 2025
1caa00c
Merge branch 'master' of github.com:FuelLabs/fuels-ts into ps/feat/pr…
petertonysmith94 Jan 7, 2025
ac03f64
chore: refactored the burnable assets to a helper
petertonysmith94 Jan 7, 2025
9c4080c
chore: use `autoCost`
petertonysmith94 Jan 7, 2025
16a6b07
chore: breaking change
petertonysmith94 Jan 7, 2025
262bba4
docs: added docs on asset burn
petertonysmith94 Jan 7, 2025
4ff6361
speeling
petertonysmith94 Jan 7, 2025
ad96a1a
chore: changeset
petertonysmith94 Jan 7, 2025
c408eda
lintfix
petertonysmith94 Jan 7, 2025
ad30912
Merge branch 'master' of github.com:FuelLabs/fuels-ts into ps/feat/pr…
petertonysmith94 Jan 7, 2025
4004a0a
chore: allow asset burn via `sendTransaction` options
petertonysmith94 Jan 7, 2025
c5a5b7e
petertonysmith94 Jan 7, 2025
a572ca4
Merge branch 'master' of github.com:FuelLabs/fuels-ts into ps/feat/pr…
petertonysmith94 Jan 7, 2025
6f6a156
Update apps/docs/src/guide/transactions/transaction-request.md
petertonysmith94 Jan 7, 2025
82f472d
chore: added asset burn validation to wallet
petertonysmith94 Jan 8, 2025
3eef294
chore: update wallet-unlocked tx example to be valid
petertonysmith94 Jan 8, 2025
8b2c598
Merge branch 'ps/feat/prevent-illicit-burn' of github.com:FuelLabs/fu…
petertonysmith94 Jan 8, 2025
280db16
Merge branch 'master' of github.com:FuelLabs/fuels-ts into ps/feat/pr…
petertonysmith94 Jan 8, 2025
68e3a6a
chore: update test assertions
petertonysmith94 Jan 8, 2025
4343f71
Merge branch 'master' into ps/feat/prevent-illicit-burn
petertonysmith94 Jan 8, 2025
16985a3
Merge branch 'master' into ps/feat/prevent-illicit-burn
petertonysmith94 Jan 8, 2025
a2e6bc3
Merge branch 'master' into ps/feat/prevent-illicit-burn
nedsalk Jan 8, 2025
43cba99
Merge branch 'master' into ps/feat/prevent-illicit-burn
arboleya Jan 9, 2025
b321ec8
chore: added asset burn validation for `MessageCoin`
petertonysmith94 Jan 9, 2025
0179db4
Merge branch 'ps/feat/prevent-illicit-burn' of github.com:FuelLabs/fu…
petertonysmith94 Jan 9, 2025
62dc663
chore: update validation check
petertonysmith94 Jan 9, 2025
33e5ea9
chore: use transactionRequest for helpers
petertonysmith94 Jan 9, 2025
b6741da
Merge branch 'master' into ps/feat/prevent-illicit-burn
arboleya Jan 10, 2025
f232412
Merge branch 'master' into ps/feat/prevent-illicit-burn
danielbate Jan 10, 2025
d18c60f
Merge branch 'master' into ps/feat/prevent-illicit-burn
arboleya Jan 10, 2025
28b9226
Merge branch 'master' into ps/feat/prevent-illicit-burn
petertonysmith94 Jan 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/docs/src/guide/transactions/transaction-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ The transaction ID is a SHA-256 hash of the entire transaction request. This can

### Burning assets

Assets can be burnt as part of a transaction that has inputs without associated output change. The SDK validates against this behavior, so we need to implicitly enable this by sending the transaction with the `enableAssetBurn` option set to `true`.
Assets can be burnt as part of a transaction that has inputs without associated output change. The SDK validates against this behavior, so we need to explicitly enable this by sending the transaction with the `enableAssetBurn` option set to `true`.

<<< @./snippets/transaction-request/asset-burn.ts#asset-burn{ts:line-numbers}

Expand Down