-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: export test and cli utilities in fuels
umbrella package
#2637
chore: export test and cli utilities in fuels
umbrella package
#2637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve
I think we should test the next
tagged CLI after it's merged into release :)
807e4d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maschad you searched for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out onto this branch there are still a number of files that import from:
@fuel-ts/errors/test-utils
@fuel-ts/account/test-utils
@fuel-ts/utils/test-utils
There's also some outdated docs / snippets such as:
Thanks for the clarification, if you update the search to be explicit for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maschad we should still be importing from the mono packages themselves rather than the umbrella inside the packages though shouldn't we? Filter your search to check only where we are installing fuels
i.e. packages/fuel-gauge
and docs-snippets
. But you're correct around outdated docs.
@danielbate is right in #2637 (review). As for the snippets and some leftovers that I didn't fix, I fixed them in f980df5 and 5131778. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification @danielbate
Good job @nedsalk
Coverage Report:
Changed Files:Coverage values did not change👌. |
I exported the utils via the
fuels
umbrella package and changed imports to import fromfuels
accordingly. The changes in this PR are exclusively tied to that and runningpnpm lint:fix
afterwards.