-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: validate imports added to code snippets #1665
Conversation
Coverage report
Show new covered files 🐣
Test suite run success1515 tests passing in 265 suites. Report generated by 🧪jest coverage report action from 9d845bc |
🚀 |
…lLabs/fuels-ts into st/docs/add-imports-to-code-snippets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a small problem to fix.
Coverage Report:
Changed Files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
- In the PR description, can you also mention the fact that this PR adds validation that checks for the validity of the imports in our docs snippets?
- The FE conditional review workflow seems to be broken on this PR
#context
within code snippets #1666This PR adds a new way to generate imports within code snippets by using the
#import
flag:This final result will be: