Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix broken link for Sway types #1423

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Conversation

MartinKong1990
Copy link
Contributor

@MartinKong1990 MartinKong1990 changed the title Update packages/abi-typegen/README.md - Fix broken link for Sway types chore: Fix broken link for Sway types Nov 9, 2023
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

You'll need to generate an empty changeset as well:

Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
@arboleya
Copy link
Member

arboleya commented Nov 9, 2023

@MartinKong1990 FYI — in case you didn't see the edit on my last comment.

@MartinKong1990
Copy link
Contributor Author

@MartinKong1990 FYI — in case you didn't see the edit on my last comment.

Looks like need to install some software in my laptop for pnpm to generate an empty changeset. Any alternative solution?

@arboleya
Copy link
Member

arboleya commented Nov 9, 2023

What do you mean by "additional software"?

It should be as easy as:

cd fuels-ts
pnpm install
pnpm changeset add --empty

Then add, commit and push the generated file.

Voilà.

@MartinKong1990
Copy link
Contributor Author

Does resubmit pull request from different branch will solve the changeset problem?

@danielbate
Copy link
Member

@MartinKong1990 No, the changeset is an additional file that needs to be added to all PRs, generated using the commands that @arboleya has referenced above. For this PR, we would be expecting an empty changeset, such as in this example.

@MartinKong1990
Copy link
Contributor Author

@MartinKong1990 No, the changeset is an additional file that needs to be added to all PRs, generated using the commands that @arboleya has referenced above. For this PR, we would be expecting an empty changeset, such as in this example.

@danielbate @arboleya

Actually I use github.com web site with Windows/Chrome. No luck trying with Windows 10 and ubuntu after install different software. I suggest two possible solutions:

Solution 1: In github.com web site, I create an empty file that same as .changeset/proud-ducks-travel.md. with different name at my fork and push here.

Solution 2: Close this PR. You guys submit the PR and add me as a co-author.

@arboleya
Copy link
Member

Option 1.

@arboleya arboleya enabled auto-merge (squash) November 10, 2023 12:30
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@arboleya arboleya merged commit fc20dda into FuelLabs:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants