-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix broken link for Sway types #1423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
You'll need to generate an empty changeset as well:
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
@MartinKong1990 FYI — in case you didn't see the edit on my last comment. |
Looks like need to install some software in my laptop for pnpm to generate an empty changeset. Any alternative solution? |
What do you mean by "additional software"? It should be as easy as: cd fuels-ts
pnpm install
pnpm changeset add --empty Then Voilà. |
Does resubmit pull request from different branch will solve the changeset problem? |
@MartinKong1990 No, the changeset is an additional file that needs to be added to all PRs, generated using the commands that @arboleya has referenced above. For this PR, we would be expecting an empty changeset, such as in this example. |
Actually I use github.com web site with Windows/Chrome. No luck trying with Windows 10 and ubuntu after install different software. I suggest two possible solutions: Solution 1: In github.com web site, I create an empty file that same as .changeset/proud-ducks-travel.md. with different name at my fork and push here. Solution 2: Close this PR. You guys submit the PR and add me as a co-author. |
Option 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Old: https://fuellabs.github.io/sway/latest/basics/index.html
New: https://fuellabs.github.io/sway/v0.47.0/book/basics/built_in_types.html