fix: don't compare bn with integer (#1704)

.changeset/grumpy-countries-perform.md

@@ -0,0 +1,5 @@
+---
+"@fuel-ts/providers": patch
+---
+
+stop comparing bn with integer in coinQuantityfy helper

packages/providers/src/coin-quantity.ts

@@ -27,7 +27,7 @@ export const coinQuantityfy = (coinQuantityLike: CoinQuantityLike): CoinQuantity
   const bnAmount = bn(amount);
   return {
     assetId: hexlify(assetId),
-    amount: bnAmount.toNumber() < 1 ? bn(1) : bnAmount,
+    amount: bnAmount.lt(1) ? bn(1) : bnAmount,
     max: max ? bn(max) : undefined,
   };
 };

packages/providers/src/coin-quantityfy.test.ts

@@ -1,12 +1,19 @@
+import { BN } from '@fuel-ts/math';
+
 import { coinQuantityfy } from './coin-quantity';
 
 /**
  * @group node
  */
 describe('coinQuantityfy', () => {
-  it('should returns 1 when input is < 1', () => {
+  it('amount that is less than 1 is rounded up to 1', () => {
+    expect(coinQuantityfy([Number.MIN_VALUE]).amount.toNumber()).toEqual(1);
     expect(coinQuantityfy([0]).amount.toNumber()).toEqual(1);
-    expect(coinQuantityfy([0.9]).amount.toNumber()).toEqual(1);
+    expect(coinQuantityfy([1 - Number.EPSILON]).amount.toNumber()).toEqual(1);
+  });
+  test('amount of return value is set properly', () => {
     expect(coinQuantityfy([2]).amount.toNumber()).toEqual(2);
+    const maxPlusOne = new BN(Number.MAX_SAFE_INTEGER).add(new BN(1));
+    expect(coinQuantityfy([maxPlusOne]).amount.toString()).toEqual(maxPlusOne.toString());
   });
 });