Add txpool TxInfo time submitted #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ControlCplusControlV this adds time to txpool so it can be fetched from txpool for status info, and added Related to this: #263 |
ControlCplusControlV
approved these changes
Apr 19, 2022
Voxelot
reviewed
Apr 20, 2022
| @@ -53,7 +54,7 @@ impl TxPool { | |||
| } | |||
| // check and insert dependency | |||
| let rem = self.by_dependency.insert(&self.by_hash, db, &tx).await?; | |||
| self.by_hash.insert(tx.id(), tx.clone()); | |||
| self.by_hash.insert(tx.id(), TxInfo::new(tx.clone())); | |||
| self.by_gas_price.insert(&tx); | |||
There was a problem hiding this comment.
[nit] Unrelated to the current PR, but should we normalize these secondary indexes to just map to the tx hash instead of arc's?
There was a problem hiding this comment.
hm, maybe, i wrap it around Arc because i can clone it easily when i want to send list of transaction to block producer to use and i dont need to do deep copy, and second one is that it is used in multiple parts by_pair and by_hash
Voxelot
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.