fix(da_compression): invalid decompression of utxo id and CoinConfig fix #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82db7e1 to
ea8f325
Compare
Co-Authored-by: green <xgreenx9999@gmail.com> test: mint tx monkeypatch fix: clippy fix: undo backward compat breaking change fix: p2p test helpers overlapping output_index fix f
ea8f325 to
bc0849a
Compare
netrome
previously approved these changes
Jan 17, 2025
xgreenx
reviewed
Jan 22, 2025
crates/compression/src/decompress.rs
Outdated
| let transaction_count = transactions.len(); | ||
|
|
||
| // patch mint transaction | ||
| for tx in transactions.iter_mut() { |
There was a problem hiding this comment.
Last transition is always mint, I think we can assume it and avoid iteration.
crates/compression/src/decompress.rs
Outdated
Comment on lines
231
to
232
| // we should probably include the mint TxPointer in the compression if we decide to support | ||
| // multiple assets for mints, i.e more than 1 mint tx per block |
There was a problem hiding this comment.
To support multiple assets to pay for fee, we will just introduce MintV2, with vector of assets and fee.
| @@ -157,6 +121,54 @@ impl GenesisCommitment for Coin { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "test-helpers")] | |||
| pub mod coin_config_helpers { | |||
There was a problem hiding this comment.
This code not only used in tests, it is used in production in the case of state config.
There was a problem hiding this comment.
I see it used in 2 places in chain-config/src/config/state.rs, random_testnet() and local_testnet() both of which are hidden behind test-helpers. is the code you're talking about in a different repo?
There was a problem hiding this comment.
Hmm, maybe we don't use it anymore in the state config, then okay=) It would be nice to put the section in decompression under the same feature flag too then
Comment on lines
312
to
318
| let mut bytes = [0u8; 32]; | ||
| let tx_index = c.tx_pointer.tx_index(); | ||
| bytes[..std::mem::size_of_val(&tx_index)] | ||
| .copy_from_slice(&tx_index.to_be_bytes()); | ||
| return Ok(fuel_core_types::fuel_tx::UtxoId::new( | ||
| bytes[..size_of::<u16>()].copy_from_slice(&c.output_index.to_be_bytes()); | ||
|
|
||
| let utxo_id = fuel_core_types::fuel_tx::UtxoId::new( | ||
| fuel_core_types::fuel_tx::TxId::from(bytes), | ||
| 0, | ||
| )); | ||
| c.output_index, | ||
| ); |
There was a problem hiding this comment.
It would be nice to use the same function here and in CoinConfigGenerator. Could you reuse it in both places please to connect them?
Dentosal
approved these changes
Jan 22, 2025
AurelienFT
approved these changes
Jan 22, 2025
Merged
MitchTurner
added a commit
that referenced
this pull request
Jan 22, 2025
## Version v0.41.1 * fault_proving(compression): include block_id in da compressed block headers by @rymnc in #2551 * chore: Add myself and Andrea as codeowner for graphql API + related crates by @netrome in #2570 * fix(integration_tests): remove flake from produce_block__l1_committed_block_affects_gas_price by @rymnc in #2566 * bugfix: Improve the `BlockCommitterHttpApi` client to use `url` apis better by @MitchTurner in #2599 * Fix version compatibility error by @AurelienFT in #2608 * Improve error messages for responses from committer by @MitchTurner in #2609 * Update async processor tests by @rafal-ch in #2577 * The amount of returned dust coins is limited by factor relative to the amount of selected big coins by @rafal-ch in #2610 * fix(da_compression): invalid decompression of utxo id and CoinConfig fix by @rymnc in #2593 * Use latest gas price to estimate next price for tx pool checks by @MitchTurner in #2612 * Set Latest Recorded Height on startup by @MitchTurner in #2603 * Use latest gas price to estimate next block gas price during dry runs by @MitchTurner in #2615 * Check that fuel-core lib builds correctly without default features by @rafal-ch in #2594 * Expose indexation status in `NodeInfo` endpoint by @rafal-ch in #2595 **Full Changelog**: v0.41.0...v0.41.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
some investigation related to why transaction ids were mismatching before compression and after decompression
Description
AI generated:
Code Organization:
crates/chain-config/src/config/coin.rs: MovedCoinConfigGeneratorto a newcoin_config_helpersmodule and updated its implementation to use aCoinCounttype.CoinConfigGeneratoracross multiple files to use the newcoin_config_helpersmodule. [1] [2] [3] [4] [5] [6] [7]Decompression Logic:
crates/compression/src/decompress.rs: Modified the decompression logic to handle mint transactions correctly and ensure the TxPointer is set appropriately. [1] [2]Testing and Configuration:
tests/tests/da_compression.rs: Enhanced the test for fetching DA compressed blocks from GraphQL by adding additional checks and ensuring the transactions' IDs match. [1] [2]Miscellaneous:
whereclauses to clean up the codebase. [1] [2] [3] [4] [5] [6]Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]