Capitalize GQL field descriptions #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlicanC
suggested changes
Apr 3, 2022
Voxelot
approved these changes
Apr 4, 2022
vlopes11
added a commit
that referenced
this pull request
Sep 12, 2022
This commit introduces the benchmarks for fuel-vm. It covers the first phase of #256 and targets individual instructions with the rocksdb/database backend. This targets gas instrumentalization, so we skip benchmarking for predicate cases. This uses a dedicated component of fuel-core so it will be easier to isolate and extend this component into block checking, and maybe to add some script to parse the output from criterion. The benchmark is created from an isolated state of the VM that is ready to execute a given instruction. It is sub-optimal in the case of contract state & call since the call overhead will always be added to any instruction to be checked inside of a contract (i.e. SWW). As next step, we need to make an API in fuel-vm to allow users to perform the operations of a call without executing the contract code. In other words, just load the contract code, add the call frame to the stack and prepare the registers. After this phase is complete, we need to benchmark beyond instructions to a block level so the post-execution steps (database commit, etc) is also accounted.
Merged
vlopes11
added a commit
that referenced
this pull request
Sep 12, 2022
This commit introduces the benchmarks for fuel-vm. It covers the first phase of #256 and targets individual instructions with the rocksdb/database backend. This targets gas instrumentalization, so we skip benchmarking for predicate cases. This uses a dedicated component of fuel-core so it will be easier to isolate and extend this component into block checking, and maybe to add some script to parse the output from criterion. The benchmark is created from an isolated state of the VM that is ready to execute a given instruction. It is sub-optimal in the case of contract state & call since the call overhead will always be added to any instruction to be checked inside of a contract (i.e. SWW). As next step, we need to make an API in fuel-vm to allow users to perform the operations of a call without executing the contract code. In other words, just load the contract code, add the call frame to the stack and prepare the registers. After this phase is complete, we need to benchmark beyond instructions to a block level so the post-execution steps (database commit, etc) is also accounted.
vlopes11
added a commit
that referenced
this pull request
Sep 19, 2022
This commit introduces the benchmarks for fuel-vm. It covers the first phase of #256 and targets individual instructions with the rocksdb/database backend. This targets gas instrumentalization, so we skip benchmarking for predicate cases. This uses a dedicated component of fuel-core so it will be easier to isolate and extend this component into block checking, and maybe to add some script to parse the output from criterion. The benchmark is created from an isolated state of the VM that is ready to execute a given instruction. It is sub-optimal in the case of contract state & call since the call overhead will always be added to any instruction to be checked inside of a contract (i.e. SWW). As next step, we need to make an API in fuel-vm to allow users to perform the operations of a call without executing the contract code. In other words, just load the contract code, add the call frame to the stack and prepare the registers. After this phase is complete, we need to benchmark beyond instructions to a block level so the post-execution steps (database commit, etc) is also accounted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done to fix #123 , I believe I regenerated the
schema.sdlcorrectly but not too familiar so let me know if I missed a step. Went looking for fields of error infuel-core/schema/*so its also possible I may have missed other GQL descriptions, I also tried to avoid capitalizing words which reference variables (likeutxo_id) and instead added prefixes to those to fit in line with the new style while maintaining clarity.