Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding monitoring ingress #242

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Adding monitoring ingress #242

merged 4 commits into from
Mar 30, 2022

Conversation

rfuelsh
Copy link
Member

@rfuelsh rfuelsh commented Mar 30, 2022

-Adding monitoring ingress to route to grafana

  • updating ingress deploy scripts
  • update ingress env names

https://monitoring.swayswap.io what deployed from this PR

@rfuelsh rfuelsh self-assigned this Mar 30, 2022
@rfuelsh rfuelsh linked an issue Mar 30, 2022 that may be closed by this pull request
@rfuelsh rfuelsh requested review from uberscott and Voxelot March 30, 2022 01:18
Copy link

@uberscott uberscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you carefully split ingress_dns into fuel_core_ingress_dns and monitoring_ingress_dns. Well done. I wish I was good like you.

@rfuelsh rfuelsh requested a review from uberscott March 30, 2022 16:32
@rfuelsh
Copy link
Member Author

rfuelsh commented Mar 30, 2022

thanks @uberscott - lemme know if any changes are needed- thanks for your help going over this PR

fuel_core_ingress_http_port="80"

# Monitoring Environment variables
grafana_ingress_dns="helloworld@monitoring.com"
Copy link
Member

@Voxelot Voxelot Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a regular domain like monitoring.example.com instead of an email?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Voxelot - you are right- updated just now

Voxelot
Voxelot previously approved these changes Mar 30, 2022
@rfuelsh rfuelsh merged commit b86ed97 into master Mar 30, 2022
@rfuelsh rfuelsh deleted the add-grafana-ingress branch March 30, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Setup grafana ingress route
3 participants