-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding monitoring ingress #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you carefully split ingress_dns into fuel_core_ingress_dns and monitoring_ingress_dns. Well done. I wish I was good like you.
thanks @uberscott - lemme know if any changes are needed- thanks for your help going over this PR |
deployment/scripts/.env
Outdated
fuel_core_ingress_http_port="80" | ||
|
||
# Monitoring Environment variables | ||
grafana_ingress_dns="helloworld@monitoring.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a regular domain like monitoring.example.com
instead of an email?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Voxelot - you are right- updated just now
-Adding monitoring ingress to route to grafana
https://monitoring.swayswap.io what deployed from this PR