Enforce the block size limit

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Added
 - [2135](https://github.com/FuelLabs/fuel-core/pull/2135): Added metrics logging for number of blocks served over the p2p req/res protocol.
 - [2151](https://github.com/FuelLabs/fuel-core/pull/2151): Added limitations on gas used during dry_run in API.
+- [2188](https://github.com/FuelLabs/fuel-core/pull/2188): Added the new variant `V2` for the `ConsensusParameters` which contains the new `block_transaction_size_limit` parameter.
 
 ### Changed
 

Cargo.toml

@@ -140,3 +140,6 @@ itertools = { version = "0.12", default-features = false }
 insta = "1.8"
 tempfile = "3.4"
 tikv-jemallocator = "0.5"
+
+[patch.crates-io]
+fuel-vm-private = { git = 'https://github.com/FuelLabs/fuel-vm.git', package = "fuel-vm", branch = "2133_block_size_consensus_parameter" }

bin/fuel-core/chainspec/local-testnet/chain_config.json

@@ -1,7 +1,7 @@
 {
   "chain_name": "Local testnet",
   "consensus_parameters": {
-    "V1": {
+    "V2": {
       "tx_params": {
         "V1": {
           "max_inputs": 255,
@@ -293,6 +293,7 @@
       },
       "base_asset_id": "f8f8b6283d7fa5b672b530cbb84fcccb4ff8dc40f8176ef4544ddb1f1952ad07",
       "block_gas_limit": 30000000,
+      "block_transaction_size_limit": 129024,
       "privileged_address": "9f0e19d6c2a6283a3222426ab2630d35516b1799b503f37b02105bebe1b8a3e9"
     }
   },

crates/client/assets/schema.sdl

@@ -198,6 +198,7 @@ type ConsensusParameters {
 	feeParams: FeeParameters!
 	baseAssetId: AssetId!
 	blockGasLimit: U64!
+	blockTransactionSizeLimit: U64!
 	chainId: U64!
 	gasCosts: GasCosts!
 	privilegedAddress: Address!
@@ -210,6 +211,7 @@ type ConsensusParametersPurpose {
 
 enum ConsensusParametersVersion {
 	V1
+	V2
 }
 
 type Contract {

crates/client/src/client/schema/chain.rs

@@ -20,6 +20,7 @@ pub struct ConsensusParameters {
     pub fee_params: FeeParameters,
     pub base_asset_id: AssetId,
     pub block_gas_limit: U64,
+    pub block_transaction_size_limit: U64,
     pub chain_id: U64,
     pub gas_costs: GasCosts,
     pub privileged_address: Address,
@@ -29,6 +30,7 @@ pub struct ConsensusParameters {
 #[cynic(schema_path = "./assets/schema.sdl")]
 pub enum ConsensusParametersVersion {
     V1,
+    V2,
 }
 
 #[derive(cynic::QueryFragment, Clone, Debug)]
@@ -493,6 +495,24 @@ impl TryFrom<ConsensusParameters> for fuel_core_types::fuel_tx::ConsensusParamet
                 }
                 .into(),
             ),
+            ConsensusParametersVersion::V2 => Ok(
+                fuel_core_types::fuel_tx::consensus_parameters::ConsensusParametersV2 {
+                    tx_params: params.tx_params.try_into()?,
+                    predicate_params: params.predicate_params.try_into()?,
+                    script_params: params.script_params.try_into()?,
+                    contract_params: params.contract_params.try_into()?,
+                    fee_params: params.fee_params.try_into()?,
+                    base_asset_id: params.base_asset_id.into(),
+                    block_gas_limit: params.block_gas_limit.into(),
+                    block_transaction_size_limit: params
+                        .block_transaction_size_limit
+                        .into(),
+                    chain_id: params.chain_id.0.into(),
+                    gas_costs: params.gas_costs.try_into()?,
+                    privileged_address: params.privileged_address.into(),
+                }
+                .into(),
+            ),
         }
     }
 }

crates/client/src/client/schema/snapshots/fuel_core_client__client__schema__chain__tests__chain_gql_query_output.snap

@@ -75,6 +75,7 @@ query {
       }
       baseAssetId
       blockGasLimit
+      blockTransactionSizeLimit
       chainId
       gasCosts {
         version

crates/fuel-core/src/query/message/test.rs

@@ -1,5 +1,6 @@
 use std::ops::Deref;
 
+use fuel_core_txpool::types::ContractId;
 use fuel_core_types::{
     blockchain::header::{
         ApplicationHeader,
@@ -8,13 +9,11 @@ use fuel_core_types::{
     },
     entities::relayer::message::MerkleProof,
     fuel_tx::{
+        AssetId,
         Script,
         Transaction,
     },
-    fuel_types::{
-        BlockHeight,
-        *,
-    },
+    fuel_types::BlockHeight,
     tai64::Tai64,
 };
 

crates/fuel-core/src/schema/chain.rs

@@ -78,6 +78,7 @@ pub enum TxParametersVersion {
 #[derive(Clone, Copy, Debug, Enum, Eq, PartialEq)]
 pub enum ConsensusParametersVersion {
     V1,
+    V2,
 }
 
 #[derive(Union)]
@@ -118,6 +119,7 @@ impl ConsensusParameters {
     async fn version(&self) -> ConsensusParametersVersion {
         match self.0.as_ref() {
             fuel_tx::ConsensusParameters::V1(_) => ConsensusParametersVersion::V1,
+            fuel_tx::ConsensusParameters::V2(_) => ConsensusParametersVersion::V2,
         }
     }
 
@@ -156,6 +158,11 @@ impl ConsensusParameters {
         self.0.block_gas_limit().into()
     }
 
+    #[graphql(complexity = "QUERY_COSTS.storage_read")]
+    async fn block_transaction_size_limit(&self) -> U64 {
+        self.0.block_transaction_size_limit().into()
+    }
+
     async fn chain_id(&self) -> U64 {
         (*self.0.chain_id()).into()
     }

crates/fuel-core/src/schema/tx/input.rs

@@ -196,7 +196,7 @@ impl From<&fuel_tx::Input> for Input {
                 tx_pointer: TxPointer(*tx_pointer),
                 witness_index: Default::default(),
                 predicate_gas_used: (*predicate_gas_used).into(),
-                predicate: HexString(predicate.clone()),
+                predicate: HexString(predicate.to_vec()),
                 predicate_data: HexString(predicate_data.clone()),
             }),
             fuel_tx::Input::Contract(contract) => Input::Contract(contract.into()),
@@ -239,7 +239,7 @@ impl From<&fuel_tx::Input> for Input {
                 witness_index: Default::default(),
                 predicate_gas_used: (*predicate_gas_used).into(),
                 data: HexString(Default::default()),
-                predicate: HexString(predicate.clone()),
+                predicate: HexString(predicate.to_vec()),
                 predicate_data: HexString(predicate_data.clone()),
             }),
             fuel_tx::Input::MessageDataSigned(
@@ -283,7 +283,7 @@ impl From<&fuel_tx::Input> for Input {
                 witness_index: Default::default(),
                 predicate_gas_used: (*predicate_gas_used).into(),
                 data: HexString(data.clone()),
-                predicate: HexString(predicate.clone()),
+                predicate: HexString(predicate.to_vec()),
                 predicate_data: HexString(predicate_data.clone()),
             }),
         }

crates/fuel-core/src/service/adapters/executor.rs

@@ -9,9 +9,13 @@ use fuel_core_types::{
 };
 
 impl fuel_core_executor::ports::TransactionsSource for TransactionsSource {
-    fn next(&self, gas_limit: u64) -> Vec<MaybeCheckedTransaction> {
+    fn next(
+        &self,
+        gas_limit: u64,
+        block_transaction_size_limit: u64,
+    ) -> Vec<MaybeCheckedTransaction> {
         self.txpool
-            .select_transactions(gas_limit)
+            .select_transactions(gas_limit, block_transaction_size_limit)
             .into_iter()
             .map(|tx| {
                 MaybeCheckedTransaction::CheckedTransaction(

crates/services/consensus_module/poa/src/service_test.rs

@@ -482,6 +482,7 @@ fn test_signing_key() -> Secret<SecretKeyWrapper> {
 }
 
 #[derive(Debug, PartialEq)]
+#[allow(clippy::large_enum_variant)]
 enum FakeProducedBlock {
     Predefined(Block),
     New(BlockHeight, Tai64),