-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ConsensusParametersVersion::V2
#2188
Merged
Dentosal
merged 16 commits into
feature/wasm-interface-breaking-changes
from
2133_block_size_consensus_parameter
Sep 17, 2024
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fa1288b
Add support for `ConsensusParametersVersion::V2`
rafal-ch 0c65bbe
Update `CHANGELOG.md`
rafal-ch 25432d2
Remove the temporary comment
rafal-ch 0a0b6c2
Fix imports in tests
rafal-ch 3068d2f
`#[allow(clippy::large_enum_variant)]` for `enum FakeProducedBlock` a…
rafal-ch 0656491
Update expected GraphQL schema
rafal-ch a1ea188
Update `state_transition_bytecode.wasm`
rafal-ch 7c14352
Merge remote-tracking branch 'upstream/master' into 2133_block_size_c…
rafal-ch b7d8da6
Merge branch 'feature/wasm-interface-breaking-changes' into 2133_bloc…
rafal-ch c85879b
Update patch for `fuel-vm` to `master` branch
rafal-ch ae183ae
Use new `fuel-vm 0.57.0`
xgreenx 8c661dd
Updated CHANGELOG.md
xgreenx dba42fc
Merge branch 'refs/heads/feature/wasm-interface-breaking-changes' int…
xgreenx 8368451
Resolve conflict
xgreenx 975cc74
Make test happy
xgreenx 879b566
Merge branch 'feature/wasm-interface-breaking-changes' into 2133_bloc…
Dentosal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-14.7 KB
(99%)
bin/fuel-core/chainspec/local-testnet/state_transition_bytecode.wasm
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,6 +75,7 @@ query { | |
} | ||
baseAssetId | ||
blockGasLimit | ||
blockTransactionSizeLimit | ||
chainId | ||
gasCosts { | ||
version | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I first read it, I understood that it was the maximum size for a transaction. I think I misunderstood because the word transaction is singular. IMO, it should be plural.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the name could indeed be slightly improved. However, it's already merged in
fuel-vm
here.In the follow-up PR to
fuel-core
I'll make sure that this is comprehensively documented.