Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove structopt in favour of clap v3 #189

Merged
merged 2 commits into from
Feb 28, 2022
Merged

remove structopt in favour of clap v3 #189

merged 2 commits into from
Feb 28, 2022

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Feb 28, 2022 •
edited
Loading

We recently removed importing structopt directly in sway, and instead use clap v3 because structopt is now built-in. See this PR

As structopt uses clap v2 internally, removing it in favor of clap v3 means we only need to build one version of the library instead of 2.

@JoshuaBatty JoshuaBatty self-assigned this Feb 28, 2022
vlopes11
vlopes11 reviewed Feb 28, 2022
View reviewed changes
@JoshuaBatty
Copy link
Member Author

clap dependency has been changed from version = "3.1.2" to version = "3.1" as per @vlopes11 suggestion

@adlerjohn adlerjohn requested a review from vlopes11 February 28, 2022 16:49
adlerjohn
adlerjohn reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but will defer to @Voxelot and @vlopes11

vlopes11
vlopes11 approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clean replace

Voxelot
Voxelot approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@Voxelot Voxelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, appreciate the PR!

@JoshuaBatty
Copy link
Member Author

Excellent, thanks!

@JoshuaBatty JoshuaBatty merged commit ef7835d into master Feb 28, 2022
@JoshuaBatty JoshuaBatty deleted the josh/clap-v3 branch February 28, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn left review comments

@Voxelot Voxelot Voxelot approved these changes

@vlopes11 vlopes11 vlopes11 approved these changes

Assignees

@JoshuaBatty JoshuaBatty

Labels
None yet
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoshuaBatty @Voxelot @adlerjohn @vlopes11