-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UtxoId changes #114
UtxoId changes #114
Conversation
Is this good to go? |
It is still not good to go, i want to check some more small things, and want to Brandon to look at it so that he is familiar with it, it is more impactful than fuel-vm. |
@@ -1510,9 +1510,9 @@ dependencies = [ | |||
"env_logger", | |||
"fuel-asm", | |||
"fuel-storage", | |||
"fuel-tx", | |||
"fuel-tx 0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like we're getting mismatched versions of fuel-tx somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably some library that uses fuel-tx
or fuel-vm
is not updated, will check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given how messy this is, and how the example project is more of an integration thing, should it simply be removed from the workspace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to be removed or moved to somewhere else if still needed (not sure where).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the lockfile can be clobbered in #140.
changes for UtxoId: FuelLabs/fuel-tx#53