Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove H160 from config and use Bytes20 #469

Closed
rakita opened this issue Jul 8, 2022 · 1 comment
Closed

Remove H160 from config and use Bytes20 #469

rakita opened this issue Jul 8, 2022 · 1 comment
Assignees
@AurelienFT
Labels
fuel-core fuel-relayer good first issue Good for newcomers tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@rakita
Copy link
Contributor

rakita commented Jul 8, 2022

This is low priority task and consists of removing fuel-relayer H160 config field and cli options and replacing them with native Bytes20 alternatives.
Bytes20 will be introduces in fuel-types version v0.5.2 or higher.
@adlerjohn adlerjohn moved this to Todo in Fuel Network Jul 8, 2022
@adlerjohn
Copy link
Contributor

Ref: FuelLabs/fuel-types#40

@ControlCplusControlV ControlCplusControlV self-assigned this Aug 21, 2022
@xgreenx xgreenx added the tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. label Jan 31, 2023
@sdankel sdankel removed this from Fuel Network Sep 5, 2023
@MitchTurner MitchTurner added the good first issue Good for newcomers label May 30, 2024
@AurelienFT AurelienFT mentioned this issue Jun 9, 2024
Closed
9 tasks
@AurelienFT AurelienFT mentioned this issue Aug 20, 2024
Merged
5 tasks
xgreenx added a commit that referenced this issue Aug 27, 2024
@AurelienFT @xgreenx
Replace H160 in config and cli options of relayer by Bytes20 (#2116)
2f1c3b7 
## Linked Issues/PRs
#469

## Description

Replace H160 in config and cli options of relayer by Bytes20. This might
cause a bit of performance impact as it's needed to transform them to
`H160` to interact with `ethers_core` dependency.

(This PR follows #1951)

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here

---------

Co-authored-by: green <xgreenx9999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurelienFT AurelienFT

Labels
fuel-core fuel-relayer good first issue Good for newcomers tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@adlerjohn @MitchTurner @rakita @xgreenx @AurelienFT @ControlCplusControlV