Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RTE): button text overflow #1173

Merged
merged 9 commits into from
Jan 23, 2025
Merged

fix(RTE): button text overflow #1173

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
385a911
feat(RTE): button text overflow
peter-tudosa Jan 23, 2025
f1a13c6
changeset edit
peter-tudosa Jan 23, 2025
f8435ae
fix(RTE): vertical alignment and box sizing issues
peter-tudosa Jan 23, 2025
c97b054
fix(RTE): box sizing issues
peter-tudosa Jan 23, 2025
17e6355
Update packages/guideline-blocks-settings/src/components/RichTextEdit…
peter-tudosa Jan 23, 2025
314be88
Update packages/guideline-blocks-settings/src/components/RichTextEdit…
peter-tudosa Jan 23, 2025
28978c4
Update packages/guideline-blocks-settings/src/components/RichTextEdit…
peter-tudosa Jan 23, 2025
2dc5ecb
Update packages/guideline-blocks-settings/src/components/RichTextEdit…
peter-tudosa Jan 23, 2025
ddfccb9
fix(RTE): small tweaks for proper word breaking
peter-tudosa Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curvy-steaks-rush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@frontify/guideline-blocks-settings": patch
---

feat(RTE): prevent text overflow from button
26 changes: 17 additions & 9 deletions ...deline-blocks-settings/src/components/RichTextEditor/plugins/ButtonPlugin/utils/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,22 @@

import { type CSSProperties } from 'react';

const DefaulButtonStyles: CSSProperties = {
ragi96 marked this conversation as resolved.
Show resolved Hide resolved
peter-tudosa marked this conversation as resolved.
Show resolved Hide resolved
marginTop: '10px',
marginBottom: '10px',
display: 'inline-block',
wordBreak: 'break-word',
overflow: 'hidden',
textOverflow: 'ellipsis',
maxWidth: '100%',
whiteSpace: 'nowrap',
ragi96 marked this conversation as resolved.
Show resolved Hide resolved
verticalAlign: 'middle',
boxSizing: 'border-box',
};

export const BlockButtonStyles: Record<string, CSSProperties & { hover?: CSSProperties }> = {
buttonPrimary: {
...DefaulButtonStyles,
peter-tudosa marked this conversation as resolved.
Show resolved Hide resolved
fontFamily: 'var(--f-theme-settings-button-primary-font-family)',
fontSize: 'var(--f-theme-settings-button-primary-font-size)',
fontWeight: 'var(--f-theme-settings-button-primary-font-weight)',
Expand All @@ -19,9 +33,7 @@ export const BlockButtonStyles: Record<string, CSSProperties & { hover?: CSSProp
borderRadius: 'var(--f-theme-settings-button-primary-border-radius)',
borderWidth: 'var(--f-theme-settings-button-primary-border-width)',
color: 'var(--f-theme-settings-button-primary-color)',
marginTop: '10px',
marginBottom: '10px',
display: 'inline-block',

hover: {
backgroundColor: 'var(--f-theme-settings-button-primary-background-color-hover)',
borderColor: 'var(--f-theme-settings-button-primary-border-color-hover)',
Expand All @@ -30,6 +42,7 @@ export const BlockButtonStyles: Record<string, CSSProperties & { hover?: CSSProp
},

buttonSecondary: {
...DefaulButtonStyles,
peter-tudosa marked this conversation as resolved.
Show resolved Hide resolved
fontFamily: 'var(--f-theme-settings-button-secondary-font-family)',
fontSize: 'var(--f-theme-settings-button-secondary-font-size)',
fontWeight: 'var(--f-theme-settings-button-secondary-font-weight)',
Expand All @@ -45,9 +58,6 @@ export const BlockButtonStyles: Record<string, CSSProperties & { hover?: CSSProp
borderRadius: 'var(--f-theme-settings-button-secondary-border-radius)',
borderWidth: 'var(--f-theme-settings-button-secondary-border-width)',
color: 'var(--f-theme-settings-button-secondary-color)',
display: 'inline-block',
marginTop: '10px',
marginBottom: '10px',
hover: {
backgroundColor: 'var(--f-theme-settings-button-secondary-background-color-hover)',
borderColor: 'var(--f-theme-settings-button-secondary-border-color-hover)',
Expand All @@ -56,6 +66,7 @@ export const BlockButtonStyles: Record<string, CSSProperties & { hover?: CSSProp
},

buttonTertiary: {
...DefaulButtonStyles,
peter-tudosa marked this conversation as resolved.
Show resolved Hide resolved
fontFamily: 'var(--f-theme-settings-button-tertiary-font-family)',
fontSize: 'var(--f-theme-settings-button-tertiary-font-size)',
fontWeight: 'var(--f-theme-settings-button-tertiary-font-weight)',
Expand All @@ -71,9 +82,6 @@ export const BlockButtonStyles: Record<string, CSSProperties & { hover?: CSSProp
borderRadius: 'var(--f-theme-settings-button-tertiary-border-radius)',
borderWidth: 'var(--f-theme-settings-button-tertiary-border-width)',
color: 'var(--f-theme-settings-button-tertiary-color)',
display: 'inline-block',
marginTop: '10px',
marginBottom: '10px',
hover: {
backgroundColor: 'var(--f-theme-settings-button-tertiary-background-color-hover)',
borderColor: 'var(--f-theme-settings-button-tertiary-border-color-hover)',
Expand Down
Loading