🧑‍💻 Unify Menu link url naming with Footer component

Frontendland · Sep 30, 2024 · f9e98e7 · f9e98e7
1 parent acf1121
commit f9e98e7
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/src/components/Menu/Menu.astro b/src/components/Menu/Menu.astro
@@ -56,7 +56,7 @@ const wrapMenu = (logo?.url || logo?.html) && items?.length && Astro.slots.has('
                     {items.map(item => (
                         <li>
                             <a
-                                href={item.url}
+                                href={item.href}
                                 target={item.target}
                                 class:list={[item.active && styles.active]}
                             >

diff --git a/src/components/Menu/Menu.svelte b/src/components/Menu/Menu.svelte
@@ -55,7 +55,7 @@
                     {#each items as item}
                         <li>
                             <a
-                                href={item.url}
+                                href={item.href}
                                 target={item.target}
                                 class={item.active ? styles.active : null}
                             >

diff --git a/src/components/Menu/Menu.tsx b/src/components/Menu/Menu.tsx
@@ -67,7 +67,7 @@ const Menu = ({
                             {items.map((item, index) => (
                                 <li key={index}>
                                     <a
-                                        href={item.url}
+                                        href={item.href}
                                         target={item.target}
                                         className={item.active ? styles.active : undefined}
                                     >

diff --git a/src/components/Menu/menu.ts b/src/components/Menu/menu.ts
@@ -1,6 +1,6 @@
 export type MenuProps = {
     items?: {
-        url: string
+        href: string
         name: string
         target?: string
         active?: boolean

diff --git a/src/data.js b/src/data.js
@@ -74,8 +74,8 @@ export const overflowTabs = Array(10).fill({
 }))
 
 export const menu = [
-    { name: 'Home', url: '/' },
-    { name: 'Docs', url: '/docs' }
+    { name: 'Home', href: '/' },
+    { name: 'Docs', href: '/docs' }
 ]
 
 export const menuLogo = {

diff --git a/src/static/Layout.astro b/src/static/Layout.astro
@@ -21,11 +21,11 @@ const menu = {
         html: logo
     },
     items: [
-        { url: '/svelte', name: 'Svelte', active: isPath('svelte') },
-        { url: '/react', name: 'React', active: isPath('react') },
-        { url: '/themes', name: 'Themes', active: isPath('themes') },
-        { url: '/resets', name: 'Resets', active: isPath('resets') },
-        { url: '/utilities', name: 'Utilities', active: isPath('utilities') }
+        { href: '/svelte', name: 'Svelte', active: isPath('svelte') },
+        { href: '/react', name: 'React', active: isPath('react') },
+        { href: '/themes', name: 'Themes', active: isPath('themes') },
+        { href: '/resets', name: 'Resets', active: isPath('resets') },
+        { href: '/utilities', name: 'Utilities', active: isPath('utilities') }
     ]
 }