✅ Update Svelte ESLint rules

Frontendland · Dec 13, 2024 · 0212016 · 0212016
1 parent c81ec2a
commit 0212016
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 5 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,5 +1,7 @@
 {
-    "svelte.plugin.svelte.compilerWarnings": {},
+    "svelte.plugin.svelte.compilerWarnings": {
+        "element_invalid_self_closing_tag": "ignore"
+    },
     "eslint.validate": [
         "svelte"
     ],

diff --git a/eslint.config.js b/eslint.config.js
@@ -1,4 +1,5 @@
 import svelteParser from 'svelte-eslint-parser'
+import svelteConfig from './svelte.config.js'
 
 import js from '@eslint/js'
 import tsParser from '@typescript-eslint/parser'
@@ -212,7 +213,8 @@ export default [
         languageOptions: {
             parser: svelteParser,
             parserOptions: {
-                parser: tsParser
+                parser: tsParser,
+                svelteConfig
             }
         },
         rules: {

diff --git a/src/components/Menu/Menu.svelte b/src/components/Menu/Menu.svelte
@@ -68,7 +68,11 @@
         </ConditionalWrapper>
 
         {#if items?.length}
-            <button class={styles.hamburger} on:click={toggleMenu}>
+            <button
+                class={styles.hamburger}
+                on:click={toggleMenu}
+                aria-label="menu"
+            >
                 <span class={styles.meat}></span>
                 <span class={styles.meat}></span>
                 <span class={styles.meat}></span>

diff --git a/src/components/Pagination/Pagination.svelte b/src/components/Pagination/Pagination.svelte
@@ -74,6 +74,7 @@
         {#each generatedPages as _, index}
             <li>
                 <button
+                    aria-label={`page ${index + 1}`}
                     data-active={calculatedCurrentPage === index + 1 ? 'true' : null}
                     on:click={calculatedCurrentPage !== index + 1
                         ? () => paginate(index + 1)

diff --git a/svelte.config.js b/svelte.config.js
@@ -3,9 +3,11 @@ import { vitePreprocess } from '@astrojs/svelte'
 export default {
     preprocess: vitePreprocess(),
     onwarn: (warning, handler) => {
-        // Suppress false positive warnings in terminal
+        // Suppress false positive warnings in terminal and eslint
         // Edit .vscode/settings.json to also suppress warnings in VSCode
-        const ignoreWarnings = []
+        const ignoreWarnings = [
+            'element_invalid_self_closing_tag'
+        ]
 
         const warningText = [
             warning.code,