Automatic alloc detection #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindln
reviewed
Aug 30, 2020
miniz_oxide/build.rs
Outdated
|
|
||
| fn main() { | ||
| autocfg::new().emit_sysroot_crate("alloc"); | ||
| } |
|
Yeah this would be nice. @HeroicKatora does this work fine for your needs? |
|
Is it fine now @HeroicKatora ? |
HeroicKatora
approved these changes
Sep 5, 2020
mbrubeck
added a commit
to mbrubeck/zip
that referenced
this pull request
Feb 11, 2021
flate2 was pinned to versions <= 1.0.14 in zip-rs#175, because flate2 updated to a new version of miniz_oxide which increased its MSRV (zip-rs#170, Frommi/miniz_oxide#85). This was fixed in Frommi/miniz_oxide#95, so all published versions of flate2 can once agoin be built with Rust 1.34.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94
Uses
autocfgto detect the availability of thealloccrate, removing the need for a feature. This avoids forcing libraries to proxy the feature through, or awkward extra dependencies onminiz_oxideto force the feature to be enabled.I don't actually know any way this could break semver. The
no_extern_crate_allocwon't usealloc<1.36, but they're all going to be rexported instdanyway. Either way,0.4.1is only ~10 days old