-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Messenger auto_setup" checker #300
Add "Messenger auto_setup" checker #300
Conversation
@frosh-automation fix-cs |
Will this report a false positive for rabbitMQ? |
@schneider-felix |
Alright, got it. Can we add the same for rabbitMQ/Redis? |
|
I would just check if the query string contains that |
I agree. This is probably enough for 99% of setups. |
Changed it to a check that looks for auto_setup bool in the query part of the dsn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could simplify this a bit by just extracting the query part. But other than that. LGTM
src/Components/Health/Checker/PerformanceChecker/MessengerAutoSetupChecker.php
Outdated
Show resolved
Hide resolved
…SetupChecker.php Co-authored-by: Felix Schneider <69912882+schneider-felix@users.noreply.github.com>
@frosh-automation fix-cs |
@M-arcus thank you very much for your contribution. |
No description provided.