Hide a specific header from dio logger #315
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #315 +/- ##
===========================================
+ Coverage 98.40% 100.00% +1.59%
===========================================
Files 28 3 -25
Lines 566 108 -458
===========================================
- Hits 557 108 -449
+ Misses 9 0 -9 ☔ View full report in Codecov by Sentry. |
|
@Frezyx , As I understand it, I need to install Codecov. I added the Codecov app on GitHub, but I am unable to log into the Codecov site and keep receiving a 403 error. I'm quite perplexed. |
|
Hello @Ilushnik ! |
| /// Header values for the specified keys in the Set will be replaced with *****. | ||
| /// Case insensitive | ||
| final Set<String> hideHeaderValuesForKeys; |
There was a problem hiding this comment.
hideHeaderValuesForKeys is huge and hard name for this field
Can we rename it to hiddenHeaders ?
| /// [TalkerHttpLogger] settings and customization | ||
| TalkerHttpLoggerSettings settings; | ||
|
|
There was a problem hiding this comment.
I understand that this feature is same for talker_http and talker_dio but can we create separated PR with TalkerHttpLoggerSettings for talker_http. And hiddenHeaders will be added for TalkerHttpLoggerSettings in this new Pull-request ?
Added functionality based on issue #281
Values for specified by user keys will be replaced with "*****" in header.