Added configurable border width and disable flag for the shadow on tapping (helpful if you want a flat button and the elevation is 0) #107
Conversation
… the button's border - Added disableTappingShadow property, to remove the ElevatedButton's shadow upon tapping in case the user requires a flat look
There was a problem hiding this comment.
Hello @JaseElder !
Thanks a lot for this contribution
Can we fix review issues before merge ?
lib/src/group_button_body.dart
Outdated
| final List<BoxShadow> unselectedShadow; | ||
| final bool? disableTappingShadow; |
There was a problem hiding this comment.
I think it would be better if we could provide a default field shadowColor for more customization.
There was a problem hiding this comment.
Yes, good idea! I'll amend.
|
I'm not sure whether I've done the right thing with this PR edit, but it looks like the new changes are there... |
|
When does border width apply? |
Border width is by default set to 1, but a borderWidth can be provided in GroupButtonOptions() if it needs to be other than 1. |
|
Hi @Frezyx , is this blocked? |
|
@Frezyx Any news on this PR ? |
| this.unselectedShadow = defaultShadow, | ||
| this.tappingShadowColor = defaultTappingShadowColor, |
There was a problem hiding this comment.
tappingShadowColor must be null by default
|
Hello @JaseElder ! Sorry for delay 🥶 |
@Frezyx No worries! Is there something special that has to happen to have this release appear on pub.dev? It's still showing group_button: ^5.3.4 for me |
Added configurable border width and disable flag for the shadow on tapping (helpful if you want a flat button and the elevation is 0)