Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved: Focus and show password buttons #4205

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Improved: Focus and show password buttons #4205

merged 3 commits into from
Feb 7, 2022

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Feb 6, 2022

Changes proposed in this pull request:

  • make tabbed focus (:focus-visible) visible
  • make show password buttons usable with keyboard

focus-visible

How to test the feature manually:

  1. edit the settings of a feed
  2. tab through the form
  3. see the border around buttons
  4. make password visible with Enter or Space keys

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UI 🎨 User Interfaces label Feb 6, 2022
@math-GH math-GH added this to the 1.20.0 milestone Feb 6, 2022
@Alkarex Alkarex merged commit 133e0d6 into FreshRSS:edge Feb 7, 2022
@math-GH math-GH deleted the improve-focus-and-show-password-button branch February 7, 2022 14:34
@Frenzie Frenzie mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alkarex Alkarex Alkarex approved these changes

Assignees
No one assigned
Labels
UI 🎨 User Interfaces
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@math-GH @Alkarex