Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lts 4.19.44 -> 4.19.45 #48

Merged
merged 104 commits into from
May 24, 2019
Merged
Changes from 1 commit
Commits
Show all changes
104 commits
Select commit Hold shift + click to select a range
7761dbf
locking/rwsem: Prevent decrement of reader count before increment
Waiman-Long Apr 28, 2019
393ca9e
x86/speculation/mds: Revert CPU buffer clear on double fault exit
amluto May 14, 2019
b185029
x86/speculation/mds: Improve CPU buffer clear documentation
amluto May 14, 2019
7b72ca6
objtool: Fix function fallthrough detection
jpoimboe May 13, 2019
8cf1bbc
arm64: dts: rockchip: Disable DCMDs on RK3399's eMMC controller.
cmuellner Mar 22, 2019
abea1fb
ARM: dts: exynos: Fix interrupt for shared EINTs on Exynos5260
Feb 19, 2019
e2c436d
ARM: dts: exynos: Fix audio (microphone) routing on Odroid XU3
Mar 20, 2019
6eaeee1
mmc: sdhci-of-arasan: Add DTS property to disable DCMDs.
cmuellner Mar 22, 2019
921bc15
ARM: exynos: Fix a leaked reference by adding missing of_node_put
taskset Mar 5, 2019
26eb5e7
power: supply: axp288_charger: Fix unchecked return value
GustavoARSilva Mar 18, 2019
592127e
power: supply: axp288_fuel_gauge: Add ACEPC T8 and T11 mini PCs to th…
jwrdegoede Apr 22, 2019
222abad
arm64: mmap: Ensure file offset is treated as unsigned
milk163 Apr 29, 2019
6d696ce
arm64: arch_timer: Ensure counter register reads occur with seqlock held
wildea01 Apr 29, 2019
26e7d2a
arm64: compat: Reduce address limit
fvincenzo Apr 1, 2019
f273cd1
arm64: Clear OSDLR_EL1 on CPU boot
Apr 8, 2019
d8d751e
arm64: Save and restore OSDLR_EL1 across suspend/resume
Apr 8, 2019
2ea1a37
sched/x86: Save [ER]FLAGS on context switch
Feb 14, 2019
c1ec6be
crypto: crypto4xx - fix ctr-aes missing output IV
chunkeey Apr 22, 2019
7a32ad3
crypto: crypto4xx - fix cfb and ofb "overran dst buffer" issues
chunkeey Apr 22, 2019
3b5ddd5
crypto: salsa20 - don't access already-freed walk.iv
ebiggers Apr 10, 2019
fe632ee
crypto: chacha20poly1305 - set cra_name correctly
ebiggers Mar 31, 2019
07d677a
crypto: ccp - Do not free psp_master when PLATFORM_INIT fails
codomania Apr 8, 2019
66f5de6
crypto: vmx - fix copy-paste error in CTR mode
daxtens Mar 15, 2019
aabf86f
crypto: skcipher - don't WARN on unprocessed data after slow walk step
ebiggers Mar 31, 2019
7a19a4b
crypto: crct10dif-generic - fix use via crypto_shash_digest()
ebiggers Mar 31, 2019
e7fd8a2
crypto: x86/crct10dif-pcl - fix use via crypto_shash_digest()
ebiggers Mar 31, 2019
63efe31
crypto: arm64/gcm-aes-ce - fix no-NEON fallback code
ebiggers Mar 13, 2019
9a61ab6
crypto: gcm - fix incompatibility between "gcm" and "gcm_base"
ebiggers Apr 18, 2019
b7d2adf
crypto: rockchip - update IV buffer to contain the next IV
ElonZhang0328 Apr 12, 2019
69b9d32
crypto: arm/aes-neonbs - don't access already-freed walk.iv
ebiggers Apr 10, 2019
d42d342
crypto: arm64/aes-neonbs - don't access already-freed walk.iv
ebiggers Apr 10, 2019
003cf67
mmc: core: Fix tag set memory leak
May 2, 2019
741e3ef
ALSA: line6: toneport: Fix broken usage of timer for delayed execution
tiwai May 8, 2019
30dda27
ALSA: usb-audio: Fix a memory leak bug
Apr 27, 2019
8c827cd
ALSA: hda/hdmi - Read the pin sense from register when repolling
jason77-wang May 6, 2019
4ac6316
ALSA: hda/hdmi - Consider eld_valid when reporting jack event
jason77-wang May 6, 2019
d33f606
ALSA: hda/realtek - EAPD turn on later
KailangYang Apr 26, 2019
e13bac4
ALSA: hdea/realtek - Headset fixup for System76 Gazelle (gaze14)
jackpot51 May 7, 2019
7295359
ASoC: max98090: Fix restore of DAPM Muxes
jonhunter May 1, 2019
df9f111
ASoC: RT5677-SPI: Disable 16Bit SPI Transfers
cujomalainey May 3, 2019
975ef5c
ASoC: fsl_esai: Fix missing break in switch statement
TE-N-ShengjiuWang Apr 28, 2019
f371425
ASoC: codec: hdac_hdmi add device_link to card device
libinyang Apr 13, 2019
1bfceb3
bpf, arm64: remove prefetch insn in xadd mapping
borkmann Apr 26, 2019
642de1c
crypto: ccree - remove special handling of chained sg
gby Apr 18, 2019
7560c0a
crypto: ccree - fix mem leak on error path
gby Apr 18, 2019
766121a
crypto: ccree - don't map MAC key on stack
gby Apr 18, 2019
ca687cd
crypto: ccree - use correct internal state sizes for export
gby Apr 18, 2019
120ab82
crypto: ccree - don't map AEAD key and IV on stack
gby Apr 18, 2019
1a4fc3d
crypto: ccree - pm resume first enable the source clk
ofirdrang Apr 18, 2019
65f5c14
crypto: ccree - HOST_POWER_DOWN_EN should be the last CC access durin…
ofirdrang Apr 18, 2019
4fb3d87
crypto: ccree - add function to handle cryptocell tee fips error
ofirdrang Apr 18, 2019
681f369
crypto: ccree - handle tee fips error during power management resume
ofirdrang Apr 18, 2019
f580a54
mm/mincore.c: make mincore() more conservative
May 14, 2019
58db381
mm/huge_memory: fix vmf_insert_pfn_{pmd, pud}() crash, handle unalign…
djbw May 14, 2019
0b16b09
mm/hugetlb.c: don't put_page in lock of hugetlb_lock
May 14, 2019
a3ccc15
hugetlb: use same fault hash key for shared and private mappings
mjkravetz May 14, 2019
3574bc9
ocfs2: fix ocfs2 read inode data panic in ocfs2_iget
May 14, 2019
8bae439
userfaultfd: use RCU to free the task struct when fork fails
aagit May 14, 2019
770e46b
ACPI: PM: Set enable_for_wake for wakeup GPEs during suspend-to-idle
May 13, 2019
5185672
mfd: da9063: Fix OTP control register names to match datasheets for D…
Apr 26, 2019
dc6d69b
mfd: max77620: Fix swapped FPS_PERIOD_MAX_US values
digetx May 5, 2019
6a01793
mtd: spi-nor: intel-spi: Avoid crossing 4K address boundary on read/w…
asverdlin Mar 19, 2019
d90824e
tty: vt.c: Fix TIOCL_BLANKSCREEN console blanking if blankinterval == 0
biergaizi Mar 4, 2019
0fd2df6
tty/vt: fix write/write race in ioctl(KDSKBSENT) handler
Mar 10, 2019
001fe0d
jbd2: check superblock mapped prior to committing
Apr 6, 2019
71478ef
ext4: make sanity check in mballoc more strict
jankara Apr 6, 2019
f0f805f
ext4: ignore e_value_offs for xattrs with value-in-ea-inode
tytso Apr 10, 2019
b12a8d8
ext4: avoid drop reference to iloc.bh twice
SinkFinder Apr 25, 2019
2a18c9c
ext4: fix use-after-free race with debug_want_extra_isize
Apr 25, 2019
f795247
ext4: actually request zeroing of inode table after grow
Apr 25, 2019
45123ae
ext4: fix ext4_show_options for file systems w/o journal
dbavatar May 1, 2019
d8925a1
btrfs: Check the first key and level for cached extent buffer
adam900710 Mar 12, 2019
87dcf0c
btrfs: Correctly free extent buffer in case btree_read_extent_buffer_…
lorddoskias Mar 14, 2019
8b13bb9
btrfs: Honour FITRIM range constraints during free space trim
lorddoskias Mar 25, 2019
74ca0a7
Btrfs: send, flush dellaloc in order to avoid data loss
fdmanana Apr 15, 2019
0388d45
Btrfs: do not start a transaction during fiemap
fdmanana Apr 15, 2019
8a8f671
Btrfs: do not start a transaction at iterate_extent_inodes()
fdmanana Apr 17, 2019
ecfc882
bcache: fix a race between cache register and cacheset unregister
LiangChen77 Apr 24, 2019
8868164
bcache: never set KEY_PTRS of journal key to 0 in journal_reclaim()
Apr 24, 2019
f6de0a3
ipmi:ssif: compare block number correctly for multi-part return messages
kamlakantp Apr 24, 2019
a80da82
crypto: ccm - fix incompatibility between "ccm" and "ccm_base"
ebiggers Apr 18, 2019
986d345
fs/writeback.c: use rcu_barrier() to wait for inflight wb switches go…
May 17, 2019
c907ce3
tty: Don't force RISCV SBI console as preferred console
avpatel Apr 25, 2019
25d010f
ext4: zero out the unused memory region in the extent tree block
rsriramr May 10, 2019
0db2412
ext4: fix data corruption caused by overlapping unaligned and aligned IO
May 11, 2019
c19db36
ext4: fix use-after-free in dx_release()
May 11, 2019
316063b
ext4: avoid panic during forced reboot due to aborted journal
jankara May 17, 2019
ae31551
ALSA: hda/realtek - Corrected fixup for System76 Gazelle (gaze14)
jackpot51 May 10, 2019
e0e1dc6
ALSA: hda/realtek - Fixup headphone noise via runtime suspend
KailangYang May 10, 2019
95482af
ALSA: hda/realtek - Fix for Lenovo B50-70 inverted internal microphon…
Michal-Wadowski May 14, 2019
5b85676
jbd2: fix potential double free
May 11, 2019
3b5ea2d
KVM: x86: Skip EFER vs. guest CPUID checks for host-initiated writes
Apr 2, 2019
38f1148
KVM: lapic: Busy wait for timer to expire when using hv_timer
Apr 16, 2019
98bdd33
kbuild: turn auto.conf.cmd into a mandatory include file
masahir0y May 12, 2019
756eda9
xen/pvh: set xen_domain_type to HVM in xen_pvh_init
royger Apr 23, 2019
866f011
libnvdimm/namespace: Fix label tracking error
djbw May 1, 2019
627bb2d
iov_iter: optimize page_copy_sane()
Feb 26, 2019
f4bf101
pstore: Centralize init/exit routines
kees Oct 18, 2018
fea8b84
pstore: Allocate compression during late_initcall()
joelagnel Oct 17, 2018
953e826
pstore: Refactor compression initialization
kees Oct 17, 2018
6172ae5
ext4: fix compile error when using BUFFER_TRACE
zhangyi089 Feb 21, 2019
e8816d3
ext4: don't update s_rev_level if not required
adilger Feb 14, 2019
c3a0725
Linux 4.19.45
gregkh May 22, 2019
d92c7a5
Merge tag 'v4.19.45' into 4.19.x+fslc
schnitzeltony May 23, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
crypto: skcipher - don't WARN on unprocessed data after slow walk step
commit dcaca01 upstream.

skcipher_walk_done() assumes it's a bug if, after the "slow" path is
executed where the next chunk of data is processed via a bounce buffer,
the algorithm says it didn't process all bytes.  Thus it WARNs on this.

However, this can happen legitimately when the message needs to be
evenly divisible into "blocks" but isn't, and the algorithm has a
'walksize' greater than the block size.  For example, ecb-aes-neonbs
sets 'walksize' to 128 bytes and only supports messages evenly divisible
into 16-byte blocks.  If, say, 17 message bytes remain but they straddle
scatterlist elements, the skcipher_walk code will take the "slow" path
and pass the algorithm all 17 bytes in the bounce buffer.  But the
algorithm will only be able to process 16 bytes, triggering the WARN.

Fix this by just removing the WARN_ON().  Returning -EINVAL, as the code
already does, is the right behavior.

This bug was detected by my patches that improve testmgr to fuzz
algorithms against their generic implementation.

Fixes: b286d8b ("crypto: skcipher - Add skcipher walk interface")
Cc: <stable@vger.kernel.org> # v4.10+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
ebiggers authored and gregkh committed May 22, 2019
commit aabf86f24d9f6157960a5d702738c7a737748b11
9 changes: 7 additions & 2 deletions crypto/skcipher.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,13 @@ int skcipher_walk_done(struct skcipher_walk *walk, int err)
memcpy(walk->dst.virt.addr, walk->page, n);
skcipher_unmap_dst(walk);
} else if (unlikely(walk->flags & SKCIPHER_WALK_SLOW)) {
if (WARN_ON(err)) {
/* unexpected case; didn't process all bytes */
if (err) {
/*
* Didn't process all bytes. Either the algorithm is
* broken, or this was the last step and it turned out
* the message wasn't evenly divisible into blocks but
* the algorithm requires it.
*/
err = -EINVAL;
goto finish;
}
Expand Down