-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oelint-adv support #6
Comments
Thanks, still a bit unstable it seems. It crashes when I am typing
|
You should probably keep it disabled by default and add the possibility to enable it to the configuration page. It also needs to find a config file in https://github.com/priv-kweihmann/oelint-adv/blob/master/docs/.oelint.cfg.example Seems to work if you set it as environment variable |
|
To reproduce just wait until the language server starts and then try to edit the file. It should crash immediately Here I tried the
|
I am running Arch and the latest version of everything. Weird that it crashes for me |
Can you provide a way to disable the linter? That way I can at least still use the parser until I have figured out why it doesn't work |
Can you try I also use ArchLinux 😄 |
I just updated and restarted. It is still crashing. No idea, I will look into this next week. Something with jsonrpc. I am not good with web stuff and node |
Tooooo weird. If you don't like it, just comment https://github.com/Freed-Wu/bitbake-language-server/blob/main/src/bitbake_language_server/server.py#L83-L100. |
Can you please provide a switch to disable the linter or parser? It is failing for me even with the most minimal Don't you have any idea why the server may be missing a "Content-Length property"? |
I think the bug is resulted from incompatiable API of old oelint-XXX. Can you show pip show oelint-adv
pip show oelint-parser |
❯ pip show oelint-adv
Name: oelint_adv
Version: 4.4.1
Summary: Advanced bitbake-recipe linter
Home-page: https://github.com/priv-kweihmann/oelint-adv
Author: Konrad Weihmann
Author-email: kweihmann@outlook.com
License:
Location: /usr/lib/python3.11/site-packages
Requires: anytree, colorama, oelint-parser, urllib3
Required-by: bitbake-language-server
❯ pip show oelint-parser
Name: oelint_parser
Version: 3.3.1
Summary: Alternative parser for bitbake recipes
Home-page: https://github.com/priv-kweihmann/oelint-parser
Author: Konrad Weihmann
Author-email: kweihmann@outlook.com
License:
Location: /usr/lib/python3.11/site-packages
Requires: Deprecated, regex
Required-by: oelint_adv |
After comment |
Or simply, when you run |
Haven't tried, because I don't know how to build this from source |
When I run it in the shell, it doesn't crash. It is as soon as I edit the file |
sudo vi /usr/lib/python3.11/site-functions/bitbake-language-server/server.py the comment 83-100. |
After removing those lines, it doesn't crash anymore |
Can other features work normally? |
Well only the parser works then. When the linter is active and the server crashes, nothing works anymore obviously. |
Maybe you have an older CoC or NodeJS version? |
Do you means hover, completion, definition goto can work except diagnostic?
I use latest node v18.18.2 and latest coc 0.0.82. I want to wait other people can reproduce this bug and tell me how to reproduce. IMO, a bug cannot be reproduced also cannot be fixed. |
Yes
I am using NodeJS 21 and tried downgrading to 18, but same error. Yeah, I understand that you need to reproduce it first. Can you reproduce it with my vim configuration? |
In fact, I want to wait other users except coc.nvim, such as vim-lsp, nvim-lsp, even non-vim user who use other editor which support LSP, in order to judge if this bug only occur when user use coc.nvim, or it happened in every editors which support LSP. It is very important. Only when this bug only occur in coc.nvim, we can report to coc.nvim and request their helps. |
Just be patient and everything will go well. |
Seems so. I just tried it with https://github.com/yegappan/lsp and it doesn't crash |
I believe this bug has been fixed. The bug comes from oelint-adv will print some information about rules which The bug only occur when wait a few seconds after enter insert mode, so it is not easy to find it. Thanks for your report! |
Yeah, it works now. Thank you for fixing it! :) |
I just had a crash again after saving the file. Not sure why that happened. It was the same error message. Couldn't yet reproduce it again though. |
The content-length property bug is there again since the update. The server crashes right away |
Would be nice to have support for oelint-adv:
https://github.com/priv-kweihmann/oelint-adv
The text was updated successfully, but these errors were encountered: