Added hide to tray option

[Devenor]

Added hide to tray option

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

#59

Description

Adds optional hide to system tray behaviour on closing and/or minimizing the main window. The settings have an option to enable or disable it in the general section. The tray icon has a small menu for closing the app or opening the window again, and it can be opened by clicking on the icon too.

Screenshots

https://imgur.com/a/1TVWBJp
https://imgur.com/a/xvBEqFe

Testing

Fully tested on Windows.
The closing behaviour has been adapted for Darwin but has not been tested.

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: v0.23.2 Beta

Additional context

[absidue]

Please fix the build and revert all unrelated changes such as the dependency additions, there is no need to manually extract anything from the asar file and the translations are overkill at the moment (especially pulling in multiple dependencies just to translate 2 strings).

Even after the corrections there are still open questions such as how to handle multiple windows.

[Devenor]

Thanks for the review, I reverted the new dependencies (I didn't know you could read asar directly from node fs! It's much better now). About the i18n, if needed maybe we could send the translated text via IPC and recreate the tray.

As for how to handle multiple windows, I didn't know you could have more than one, is there some kind of setting for that?

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[absidue]

Looks like you may have mistakenly used npm instead of yarn to install the dependencies and pushed a package-lock.json file, additionally there seem to be changes to the yarn.lock file which shouldn't really be there as the dependencies are no longer changing in this PR.

[Devenor]

Yeah, I used npm, I've already deleted the package-lock.json file.

The yarn.lock though seems that needs to be updated, I just tried uploading the original file from the development branch and it fails when issuing the yarn run ci command. After a yarn install in my local environment and commiting the new file, it works.