Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons to page headers + subscription tabs #6669

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Add icons to page headers + subscription tabs #6669

wants to merge 6 commits into from

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Jan 30, 2025 •
edited by absidue
Loading

Add icons to page headers + subscription tabs

Pull Request Type

  • Feature Implementation

Related issue

closes #6267

Description

Adds icons to page headers when it makes sense to do so + adds some icons to subscription tabs (similar to trending tabs)

Screenshots

image
image
image
image
image
image

Testing

  • go to pages: subscriptions, subscribed channels, settings, user playlists, history, about (Most Popular was updated as well but I'm not aware of any public instances with api enabled + most popular enabled)
  • see new icons

Desktop

  • OS: Fedore Linux
  • OS Version: 41 KDE
  • FreeTube version: latest nightly

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 30, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 30, 2025 18:55
@ChunkyProgrammer ChunkyProgrammer changed the title Add icons to page headers Add icons to page headers + subscription tabs Jan 30, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Most Popular icon is white instead of based on the color that is defined in the settings

VirtualBoxVM_scoEvHHjv1.mp4

@absidue
Copy link
Member

absidue commented Jan 30, 2025 •
edited
Loading

On mobile the settings menu looks odd with the icon in the title, as other than a minor text colour difference it now looks the same as the labels for the sections. It might be worth removing the icon on the settings page to avoid confusion.

I also noticed that no icon was added for the search results page.

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 30, 2025
@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Jan 30, 2025 •
edited
Loading

On mobile the settings menu looks odd with the icon in the title, as other than a minor text colour difference it now looks the same as the labels for the sections. It might be worth removing the icon on the settings page to avoid confusion.

I also noticed that no icon was added for the search results page.

On mobile the settings menu looks odd with the icon in the title, as other than a minor text colour difference it now looks the same as the labels for the sections. It might be worth removing the icon on the settings page to avoid confusion.

I also noticed that no icon was added for the search results page.

I've updated it to hide the icon on the settings page on mobile and added an icon for the search results page

@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Jan 30, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Should there also be an icon here? Im not sure tbh.

VirtualBoxVM_hlyT7lZpc3.mp4

@ChunkyProgrammer
Copy link
Member Author

Should there also be an icon here? Im not sure tbh.
VirtualBoxVM_hlyT7lZpc3.mp4

It would look like this:
image

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-icons-to-page-headers branch from 3b03f51 to 9679004 Compare February 2, 2025 03:50
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

idk if you should go for that for the sake of consistency or if we shouldn't do it because it would look weird. I need the others to chime in on this one

@PikachuEXE
Copy link
Collaborator

I am fine with having icon on hash tag page
Doesn't look weird to me

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@PikachuEXE the icon always has been there. The subject is more if we should make that icon be based on the primary color theme like other icons

@PikachuEXE
Copy link
Collaborator

Looks fine in my usual theme but not sure about the other themes

@absidue
Copy link
Member

absidue commented Feb 10, 2025

I like the coloured hashtag icon.

@ChunkyProgrammer
Copy link
Member Author

Implemented the hashtag icon with color

PikachuEXE
PikachuEXE previously approved these changes Feb 12, 2025
View reviewed changes
@ChunkyProgrammer ChunkyProgrammer marked this pull request as draft February 20, 2025 13:04
auto-merge was automatically disabled February 20, 2025 13:04

Pull request was converted to draft

@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 20, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Marked as draft by accident?

@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review February 20, 2025 14:42
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 20, 2025 14:42
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 20, 2025
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-icons-to-page-headers branch from af5d3b9 to 641da96 Compare February 20, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

@absidue absidue Awaiting requested review from absidue

@PikachuEXE PikachuEXE Awaiting requested review from PikachuEXE

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PR: waiting for review For PRs that are complete, tested, and ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add an respective icon to the title of every tab
4 participants
@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @PikachuEXE