Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink mime-db even further #6659

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

absidue
Copy link
Member

@absidue absidue commented Jan 27, 2025

Shrink mime-db even further

Pull Request Type

  • Performance improvement

Related issue

Description

When I orginally added the mime-db-shrinking-loader I restricted it to only include image mimetypes and only if they weren't vendor specific x- or vnd.. However I've since realised that there is only a small set of mimetypes that are actually going to be used for images that are displayed in FreeTube, so we can just hardcode that list instead of including loads that we know we'll never need.

Screenshots

Before:
before

After:
after

Testing

  1. Right click on an image (e.g. a video or channel thumbnail)
  2. Click Save Image As
  3. Check that the image was saved correctly.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: edef122

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 27, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 27, 2025 21:53
@FreeTubeBot FreeTubeBot merged commit fb098b3 into FreeTubeApp:development Jan 28, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 28, 2025
@absidue absidue deleted the mime-db-shrinking branch January 28, 2025 05:12
SudharakaP pushed a commit to SudharakaP/FreeTube that referenced this pull request Jan 28, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jan 29, 2025
* development: (35 commits)
  Shrink mime-db even further (FreeTubeApp#6659)
  * Update play next recommended video setting to be "by default" (FreeTubeApp#6400)
  Miscellaneous performance improvements (FreeTubeApp#6658)
  Bump stylelint in the stylelint group across 1 directory (FreeTubeApp#6660)
  Bump the stylelint group across 1 directory with 4 updates (FreeTubeApp#6605)
  Fixes FreeTubeApp#5476: Adjusted z-index for tooltips to avoid overlapping with bars (FreeTubeApp#6656)
  Bump shaka-player from 4.12.8 to 4.13.0 (FreeTubeApp#6649)
  Migrate ProfileSettings, FtProfileBubble and FtProfileEdit to the composition API (FreeTubeApp#6639)
  Translated using Weblate (Arabic)
  Bump the eslint group with 4 updates (FreeTubeApp#6645)
  Bump bgutils-js from 3.1.2 to 3.1.3 (FreeTubeApp#6650)
  Translated using Weblate (Arabic)
  Translated using Weblate (Arabic)
  Bump electron from 34.0.0 to 34.0.1 (FreeTubeApp#6648)
  Bump lefthook from 1.10.9 to 1.10.10 (FreeTubeApp#6647)
  Bump the babel group with 2 updates (FreeTubeApp#6644)
  Translated using Weblate (Arabic)
  Avoid logging an error when a player cache entry does not exist (FreeTubeApp#6640)
  Move saving screenshots to the default folder to an IPC call (FreeTubeApp#6636)
  Replace rimraf dev dependency with clean script (FreeTubeApp#6638)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants