Switch FtSponsorBlockCategory to useId from sanitizeForHtmlId #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
approved these changes
Jan 21, 2025
kommunarr
approved these changes
Jan 21, 2025
ChunkyProgrammer
approved these changes
Jan 21, 2025
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jan 22, 2025
* feature/manual-progress-saving: style * Implement watch progress saving mode setting (WIP Translated using Weblate (Persian) Translated using Weblate (Croatian) Translated using Weblate (Hungarian) Translated using Weblate (Estonian) Clean up unused template refs (FreeTubeApp#6610) Switch FtSponsorBlockCategory to useId from sanitizeForHtmlId (FreeTubeApp#6611) Bump youtubei.js from 12.2.0 to 13.0.0 (FreeTubeApp#6616) Translated using Weblate (Italian) Translated using Weblate (Serbian) Translated using Weblate (Hungarian) Translated using Weblate (Chinese (Simplified Han script))
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
SudharakaP
pushed a commit
to SudharakaP/FreeTube
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch FtSponsorBlockCategory to useId from sanitizeForHtmlId
Pull Request Type
Description
This pull request switches the
FtSponsorBlockCategorycomponent from thesanitizeForHtmlIdfunction to ouruseIdpolyfill, as that component was migrated before we added that polyfill. In the Vue 3 migration we will just need to update the import. I also fixed the describe by attribute inft-selectto bearia-describedby.Desktop